Merge pull request #2003 from dhavalgshah/kceu22_bugbash/issue1999

fix:  ngclient: temp_file could be undefined #1999

Author: Jussi Kukkonen

tuf/ngclient/updater.py

@@ -275,21 +275,23 @@ def _load_local_metadata(self, rolename: str) -> bytes:
 
     def _persist_metadata(self, rolename: str, data: bytes) -> None:
         """Write metadata to disk atomically to avoid data loss."""
+        temp_file_name: Optional[str] = None
         try:
             # encode the rolename to avoid issues with e.g. path separators
             encoded_name = parse.quote(rolename, "")
             filename = os.path.join(self._dir, f"{encoded_name}.json")
             with tempfile.NamedTemporaryFile(
                 dir=self._dir, delete=False
             ) as temp_file:
+                temp_file_name = temp_file.name
                 temp_file.write(data)
             os.replace(temp_file.name, filename)
         except OSError as e:
             # remove tempfile if we managed to create one,
             # then let the exception happen
-            if temp_file:
+            if temp_file_name is not None:
                 try:
-                    os.remove(temp_file.name)
+                    os.remove(temp_file_name)
                 except FileNotFoundError:
                     pass
             raise e