Skip to content

Commit be2c8f0

Browse files
author
Martin Vrachev
committed
Metadata test full serialization cycle
Replace the usage of Metadata.to_dict inside test_valid_metadata_serialization and instead use Metadata.to_bytes() in order to test that the full serialization cycle is working as expected: Metadata.from_bytes -> Metadata.to_bytes Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
1 parent a347d03 commit be2c8f0

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

tests/test_metadata_serialization.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,15 @@ def test_invalid_metadata_serialization(self, test_data: bytes) -> None:
7373
@utils.run_sub_tests_with_dataset(valid_metadata)
7474
def test_valid_metadata_serialization(self, test_case_data: bytes) -> None:
7575
md = Metadata.from_bytes(test_case_data)
76-
input_dict = json.loads(test_case_data)
77-
self.assertDictEqual(input_dict, md.to_dict())
76+
77+
# Convert to a JSON and sort the keys the way we do in JSONSerializer.
78+
separators = (",", ":")
79+
test_json = json.loads(test_case_data)
80+
test_bytes = json.dumps(
81+
test_json, separators=separators, sort_keys=True
82+
).encode("utf-8")
83+
84+
self.assertEqual(test_bytes, md.to_bytes())
7885

7986
invalid_signatures: utils.DataSet = {
8087
"missing keyid attribute in a signature": '{ "sig": "abc" }',

0 commit comments

Comments
 (0)