Skip to content

Commit 220e854

Browse files
author
Jussi Kukkonen
committed
tests: Use the default Metadata constructor args
Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
1 parent d2f8c99 commit 220e854

2 files changed

Lines changed: 14 additions & 34 deletions

File tree

tests/generated_data/generate_md.py

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
TOP_LEVEL_ROLE_NAMES,
1717
Key,
1818
Metadata,
19-
MetaFile,
2019
Role,
2120
Root,
2221
Snapshot,
@@ -97,23 +96,15 @@ def generate_all_files(
9796
verify: Whether to verify the newly generated files with the
9897
local staored.
9998
"""
100-
root = Root(1, SPEC_VERSION, EXPIRY, {}, ROLES, True)
101-
root.add_key("root", keys["ed25519_0"])
102-
root.add_key("timestamp", keys["ed25519_1"])
103-
root.add_key("snapshot", keys["ed25519_2"])
104-
root.add_key("targets", keys["ed25519_3"])
105-
106-
md_root: Metadata[Root] = Metadata(root, {})
107-
108-
timestamp = Timestamp(1, SPEC_VERSION, EXPIRY, MetaFile(1))
109-
md_timestamp: Metadata[Timestamp] = Metadata(timestamp, {})
110-
111-
meta: Dict[str, MetaFile] = {"targets.json": MetaFile(1)}
112-
snapshot = Snapshot(1, SPEC_VERSION, EXPIRY, meta)
113-
md_snapshot: Metadata[Snapshot] = Metadata(snapshot, {})
114-
115-
targets = Targets(1, SPEC_VERSION, EXPIRY, {})
116-
md_targets: Metadata[Targets] = Metadata(targets, {})
99+
md_root = Metadata(Root(expires=EXPIRY))
100+
md_timestamp = Metadata(Timestamp(expires=EXPIRY))
101+
md_snapshot = Metadata(Snapshot(expires=EXPIRY))
102+
md_targets = Metadata(Targets(expires=EXPIRY))
103+
104+
md_root.signed.add_key("root", keys["ed25519_0"])
105+
md_root.signed.add_key("timestamp", keys["ed25519_1"])
106+
md_root.signed.add_key("snapshot", keys["ed25519_2"])
107+
md_root.signed.add_key("targets", keys["ed25519_3"])
117108

118109
for i, md in enumerate([md_root, md_timestamp, md_snapshot, md_targets]):
119110
assert isinstance(md, Metadata)

tests/repository_simulator.py

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@
6565
Key,
6666
Metadata,
6767
MetaFile,
68-
Role,
6968
Root,
7069
Snapshot,
7170
TargetFile,
@@ -176,26 +175,16 @@ def rotate_keys(self, role: str) -> None:
176175
def _initialize(self) -> None:
177176
"""Setup a minimal valid repository."""
178177

179-
targets = Targets(1, SPEC_VER, self.safe_expiry, {}, None)
180-
self.md_targets = Metadata(targets, {})
181-
182-
meta = {"targets.json": MetaFile(targets.version)}
183-
snapshot = Snapshot(1, SPEC_VER, self.safe_expiry, meta)
184-
self.md_snapshot = Metadata(snapshot, {})
185-
186-
snapshot_meta = MetaFile(snapshot.version)
187-
timestamp = Timestamp(1, SPEC_VER, self.safe_expiry, snapshot_meta)
188-
self.md_timestamp = Metadata(timestamp, {})
189-
190-
roles = {role_name: Role([], 1) for role_name in TOP_LEVEL_ROLE_NAMES}
191-
root = Root(1, SPEC_VER, self.safe_expiry, {}, roles, True)
178+
self.md_targets = Metadata(Targets(expires=self.safe_expiry))
179+
self.md_snapshot = Metadata(Snapshot(expires=self.safe_expiry))
180+
self.md_timestamp = Metadata(Timestamp(expires=self.safe_expiry))
181+
self.md_root = Metadata(Root(expires=self.safe_expiry))
192182

193183
for role in TOP_LEVEL_ROLE_NAMES:
194184
key, signer = self.create_key()
195-
root.add_key(role, key)
185+
self.md_root.signed.add_key(role, key)
196186
self.add_signer(role, signer)
197187

198-
self.md_root = Metadata(root, {})
199188
self.publish_root()
200189

201190
def publish_root(self) -> None:

0 commit comments

Comments
 (0)