Merge pull request #1876 from jku/more-details-on-verify-failure

Logging and error message improvements

Author: Jussi Kukkonen

tuf/api/metadata.py

@@ -742,6 +742,8 @@ def verify_signature(
             sslib_exceptions.UnsupportedAlgorithmError,
             SerializationError,
         ) as e:
+            # Log unexpected failure, but continue as if there was no signature
+            logger.info("Key %s failed to verify sig: %s", self.keyid, str(e))
             raise exceptions.UnsignedMetadataError(
                 f"Failed to verify {self.keyid} signature"
             ) from e

tuf/api/serialization/json.py

@@ -37,7 +37,7 @@ def deserialize(self, raw_data: bytes) -> Metadata:
             metadata_obj = Metadata.from_dict(json_dict)
 
         except Exception as e:
-            raise DeserializationError from e
+            raise DeserializationError("Failed to deserialize JSON") from e
 
         return metadata_obj
 
@@ -82,7 +82,7 @@ def serialize(self, metadata_obj: Metadata) -> bytes:
                     raise ValueError("Metadata cannot be validated!") from e
 
         except Exception as e:
-            raise SerializationError from e
+            raise SerializationError("Failed to serialize JSON") from e
 
         return json_bytes