Skip to content

Commit 17503eb

Browse files
author
Martin Vrachev
committed
Remove unnecessary copy operations
There is no need to copy "case_dict" inside serialization test functions in test_metadata_serialization.py when we are testing invalid arguments. These dictionaries are not be used after calling "from_dict" and it doesn't matter if they are empty afterward. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
1 parent cd34793 commit 17503eb

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

tests/test_metadata_serialization.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def test_signature_serialization(self, test_case_data: str) -> None:
122122
def test_invalid_signed_serialization(self, test_case_data: str) -> None:
123123
case_dict = json.loads(test_case_data)
124124
with self.assertRaises((KeyError, ValueError, TypeError)):
125-
Snapshot.from_dict(copy.deepcopy(case_dict))
125+
Snapshot.from_dict(case_dict)
126126

127127
valid_keys: utils.DataSet = {
128128
"all": '{"keytype": "rsa", "scheme": "rsassa-pss-sha256", \
@@ -155,7 +155,7 @@ def test_invalid_key_serialization(self, test_case_data: str) -> None:
155155
case_dict = json.loads(test_case_data)
156156
with self.assertRaises((TypeError, KeyError)):
157157
keyid = case_dict.pop("keyid")
158-
Key.from_dict(keyid, copy.copy(case_dict))
158+
Key.from_dict(keyid, case_dict)
159159

160160
invalid_roles: utils.DataSet = {
161161
"no threshold": '{"keyids": ["keyid"]}',
@@ -169,7 +169,7 @@ def test_invalid_key_serialization(self, test_case_data: str) -> None:
169169
def test_invalid_role_serialization(self, test_case_data: str) -> None:
170170
case_dict = json.loads(test_case_data)
171171
with self.assertRaises((KeyError, TypeError, ValueError)):
172-
Role.from_dict(copy.deepcopy(case_dict))
172+
Role.from_dict(case_dict)
173173

174174
valid_roles: utils.DataSet = {
175175
"all": '{"keyids": ["keyid"], "threshold": 3}',
@@ -276,7 +276,7 @@ def test_root_serialization(self, test_case_data: str) -> None:
276276
def test_invalid_root_serialization(self, test_case_data: str) -> None:
277277
case_dict = json.loads(test_case_data)
278278
with self.assertRaises(ValueError):
279-
Root.from_dict(copy.deepcopy(case_dict))
279+
Root.from_dict(case_dict)
280280

281281
invalid_metafiles: utils.DataSet = {
282282
"wrong length type": '{"version": 1, "length": "a", "hashes": {"sha256" : "abc"}}',
@@ -292,7 +292,7 @@ def test_invalid_root_serialization(self, test_case_data: str) -> None:
292292
def test_invalid_metafile_serialization(self, test_case_data: str) -> None:
293293
case_dict = json.loads(test_case_data)
294294
with self.assertRaises((TypeError, ValueError, AttributeError)):
295-
MetaFile.from_dict(copy.deepcopy(case_dict))
295+
MetaFile.from_dict(case_dict)
296296

297297
valid_metafiles: utils.DataSet = {
298298
"all": '{"hashes": {"sha256" : "abc"}, "length": 12, "version": 1}',
@@ -316,7 +316,7 @@ def test_metafile_serialization(self, test_case_data: str) -> None:
316316
def test_invalid_timestamp_serialization(self, test_case_data: str) -> None:
317317
case_dict = json.loads(test_case_data)
318318
with self.assertRaises((ValueError, KeyError)):
319-
Timestamp.from_dict(copy.deepcopy(case_dict))
319+
Timestamp.from_dict(case_dict)
320320

321321
valid_timestamps: utils.DataSet = {
322322
"all": '{ "_type": "timestamp", "spec_version": "1.0.0", "version": 1, "expires": "2030-01-01T00:00:00Z", \
@@ -392,7 +392,7 @@ def test_invalid_delegated_role_serialization(
392392
) -> None:
393393
case_dict = json.loads(test_case_data)
394394
with self.assertRaises(ValueError):
395-
DelegatedRole.from_dict(copy.copy(case_dict))
395+
DelegatedRole.from_dict(case_dict)
396396

397397
invalid_delegations: utils.DataSet = {
398398
"empty delegations": "{}",
@@ -453,7 +453,7 @@ def test_invalid_delegation_serialization(
453453
) -> None:
454454
case_dict = json.loads(test_case_data)
455455
with self.assertRaises((ValueError, KeyError, AttributeError)):
456-
Delegations.from_dict(copy.deepcopy(case_dict))
456+
Delegations.from_dict(case_dict)
457457

458458
valid_delegations: utils.DataSet = {
459459
"all": '{"keys": { \
@@ -490,7 +490,7 @@ def test_invalid_targetfile_serialization(
490490
) -> None:
491491
case_dict = json.loads(test_case_data)
492492
with self.assertRaises(KeyError):
493-
TargetFile.from_dict(copy.deepcopy(case_dict), "file1.txt")
493+
TargetFile.from_dict(case_dict, "file1.txt")
494494

495495
valid_targetfiles: utils.DataSet = {
496496
"all": '{"length": 12, "hashes": {"sha256" : "abc"}, \

0 commit comments

Comments
 (0)