Skip to content

Commit 0929123

Browse files
authored
Merge pull request #2578 from jku/improve-dev-docs
Improve dev docs
2 parents d8a43ac + f82e0bb commit 0929123

2 files changed

Lines changed: 23 additions & 29 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,18 @@
1-
Please fill in the fields below to submit a pull request. The more information
2-
that is provided, the better.
1+
<!--
2+
Before submitting a pull request:
3+
* Run linter and tests locally: Use "tox"
4+
* Ensure your commits are signed-off-by: Use "commit --signoff"
5+
* Make sure new code has tests and is documented
6+
* For more info, see docs/CONTRIBUTING.rst
37
4-
Fixes #<ISSUE NUMBER>
8+
Once commits are signed off and tested, describe the purpose and contents
9+
of the pull request below.
10+
-->
511

612
**Description of the changes being introduced by the pull request**:
713

8-
**Please verify and check that the pull request fulfills the following
9-
requirements**:
1014

11-
- [ ] The code follows the [Code Style Guidelines](https://github.com/secure-systems-lab/code-style-guidelines#code-style-guidelines)
12-
- [ ] Tests have been added for the bug fix or new feature
13-
- [ ] Docs have been added for the bug fix or new feature
1415

1516

17+
Fixes #<ISSUE NUMBER>
18+

docs/CONTRIBUTING.rst

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,14 @@ and must be `unit tested <#unit-tests>`_.
1313

1414
Also see `development installation instructions <https://theupdateframework.readthedocs.io/en/latest/INSTALLATION.html#install-for-development>`_.
1515

16+
DCO
17+
===
18+
19+
Contributors must indicate acceptance of the `Developer Certificate of
20+
Origin <https://developercertificate.org/>`_ by appending a ``Signed-off-by:
21+
Your Name <example@domain.com>`` to each git commit message (see `git commit
22+
--signoff <https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff>`_).
23+
1624
Testing
1725
=======
1826

@@ -63,26 +71,9 @@ via PyPI).
6371
Auto-formatting
6472
---------------
6573

66-
CI/CD will check that new TUF code is formatted with `black
67-
<https://black.readthedocs.io/>`__ and `isort <https://pycqa.github.io/isort>`__.
68-
Auto-formatting can be done on the command line:
74+
The linter in CI/CD will check that new TUF code is formatted with
75+
`ruff <https://docs.astral.sh/ruff/>`_. Auto-formatting can be done on the
76+
command line:
6977
::
7078

71-
$ black <filename>
72-
$ isort <filename>
73-
74-
or via source code editor plugin
75-
[`black <https://black.readthedocs.io/en/stable/editor_integration.html>`__,
76-
`isort <https://github.com/pycqa/isort/wiki/isort-Plugins>`__] or
77-
`pre-commit <https://pre-commit.com/>`__-powered git hooks
78-
[`black <https://black.readthedocs.io/en/stable/version_control_integration.html>`__,
79-
`isort <https://pycqa.github.io/isort/docs/configuration/pre-commit/>`__].
80-
81-
82-
DCO
83-
===
84-
85-
Contributors must also indicate acceptance of the `Developer Certificate of
86-
Origin <https://developercertificate.org/>`_ by appending a ``Signed-off-by:
87-
Your Name <example@domain.com>`` to each git commit message (see `git commit
88-
--signoff <https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff>`_).
79+
$ ruff format .

0 commit comments

Comments
 (0)