Skip to content

Commit ddd8914

Browse files
softwareckilgirdwood
authored andcommitted
module: mux: use size_t for frame and byte counts
Update the mux frame-count helpers to use and return size_t. Propagate size_t through the mux and demux processing paths. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
1 parent a4a307d commit ddd8914

3 files changed

Lines changed: 38 additions & 38 deletions

File tree

‎src/audio/mux/mux.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ static int demux_process(struct processing_module *mod,
239239
const void *source_start;
240240
size_t source_size;
241241
size_t source_bytes;
242-
uint32_t frames;
242+
size_t frames;
243243
int ret;
244244
int i;
245245

@@ -350,7 +350,7 @@ static int mux_process(struct processing_module *mod,
350350
size_t source_bytes[MUX_MAX_STREAMS] = { 0 };
351351
struct cir_buf_sink sink_buf;
352352
size_t sink_bytes, size;
353-
uint32_t frames;
353+
size_t frames;
354354
int i, idx, ret;
355355

356356
comp_dbg(dev, "entry");

‎src/audio/mux/mux.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,10 @@ struct mux_stream_data {
7373
typedef int(*demux_func)(struct comp_dev *dev, struct sof_sink *sink,
7474
struct sof_source *source, const void *source_data,
7575
const void *source_start, size_t source_size,
76-
uint32_t frames, struct mux_look_up *look_up);
76+
size_t frames, struct mux_look_up *look_up);
7777
typedef void(*mux_func)(struct comp_dev *dev, struct sof_sink *sink,
7878
struct cir_buf_sink *sink_buf, struct sof_source **sources,
79-
struct cir_buf_source *source_bufs, uint32_t frames,
79+
struct cir_buf_source *source_bufs, size_t frames,
8080
struct mux_look_up *look_up);
8181

8282
/**

‎src/audio/mux/mux_generic.c‎

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,12 @@ static void demux_check_for_wrap(struct cir_buf_sink *sink,
5959

6060
#if CONFIG_FORMAT_S16LE
6161

62-
static uint32_t demux_calc_frames_without_wrap_s16(struct cir_buf_sink *sink,
63-
struct cir_buf_source *source,
64-
struct mux_look_up *lookup)
62+
static size_t demux_calc_frames_without_wrap_s16(struct cir_buf_sink *sink,
63+
struct cir_buf_source *source,
64+
struct mux_look_up *lookup)
6565
{
66-
uint32_t frames;
67-
uint32_t min_frames;
66+
size_t frames;
67+
size_t min_frames;
6868
const void *ptr;
6969

7070
/* for demux we process each source buffer separately - dest/src for
@@ -86,13 +86,13 @@ static uint32_t demux_calc_frames_without_wrap_s16(struct cir_buf_sink *sink,
8686
return min_frames;
8787
}
8888

89-
static uint32_t mux_calc_frames_without_wrap_s16(struct cir_buf_sink *sink,
90-
struct cir_buf_source *source_bufs,
91-
struct mux_look_up *lookup)
89+
static size_t mux_calc_frames_without_wrap_s16(struct cir_buf_sink *sink,
90+
struct cir_buf_source *source_bufs,
91+
struct mux_look_up *lookup)
9292
{
9393
struct cir_buf_source *source;
94-
uint32_t frames;
95-
uint32_t min_frames;
94+
size_t frames;
95+
size_t min_frames;
9696
uint32_t elem;
9797
const void *ptr;
9898

@@ -165,15 +165,15 @@ static void demux_init_look_up_pointers_s16(struct sof_sink *sink,
165165
static int demux_s16le(struct comp_dev *dev, struct sof_sink *sink,
166166
struct sof_source *source, const void *source_data,
167167
const void *source_start, size_t source_size,
168-
uint32_t frames, struct mux_look_up *lookup)
168+
size_t frames, struct mux_look_up *lookup)
169169
{
170170
int16_t *y, *y_start, *y_end;
171171
int y_size;
172172
struct cir_buf_sink sink_buf;
173173
struct cir_buf_source source_buf;
174-
int bytes = frames * sink_get_frame_bytes(sink);
174+
size_t bytes = frames * sink_get_frame_bytes(sink);
175175
uint32_t elem;
176-
uint32_t i;
176+
size_t i;
177177
int ret;
178178

179179
comp_dbg(dev, "entry");
@@ -202,7 +202,7 @@ static int demux_s16le(struct comp_dev *dev, struct sof_sink *sink,
202202
lookup->copy_elem[0].in_ch;
203203
int16_t *dst = (int16_t *)lookup->copy_elem[0].dest -
204204
lookup->copy_elem[0].out_ch;
205-
uint32_t frames_without_wrap;
205+
size_t frames_without_wrap;
206206

207207
frames_without_wrap =
208208
demux_calc_frames_without_wrap_s16(&sink_buf, &source_buf, lookup);
@@ -244,14 +244,14 @@ static int demux_s16le(struct comp_dev *dev, struct sof_sink *sink,
244244
*/
245245
static void mux_s16le(struct comp_dev *dev, struct sof_sink *sink,
246246
struct cir_buf_sink *sink_buf, struct sof_source **sources,
247-
struct cir_buf_source *source_bufs, uint32_t frames,
247+
struct cir_buf_source *source_bufs, size_t frames,
248248
struct mux_look_up *lookup)
249249
{
250-
uint32_t i;
250+
size_t i;
251251
const int16_t *src;
252252
int16_t *dst;
253253
uint32_t elem;
254-
uint32_t frames_without_wrap;
254+
size_t frames_without_wrap;
255255

256256
comp_dbg(dev, "entry");
257257

@@ -287,13 +287,13 @@ static void mux_s16le(struct comp_dev *dev, struct sof_sink *sink,
287287

288288
#if CONFIG_FORMAT_S24LE || CONFIG_FORMAT_S32LE
289289

290-
static uint32_t mux_calc_frames_without_wrap_s32(struct cir_buf_sink *sink,
291-
struct cir_buf_source *source_bufs,
292-
struct mux_look_up *lookup)
290+
static size_t mux_calc_frames_without_wrap_s32(struct cir_buf_sink *sink,
291+
struct cir_buf_source *source_bufs,
292+
struct mux_look_up *lookup)
293293
{
294294
struct cir_buf_source *source;
295-
uint32_t frames;
296-
uint32_t min_frames;
295+
size_t frames;
296+
size_t min_frames;
297297
uint32_t elem;
298298
const void *ptr;
299299

@@ -320,12 +320,12 @@ static uint32_t mux_calc_frames_without_wrap_s32(struct cir_buf_sink *sink,
320320
return min_frames;
321321
}
322322

323-
static uint32_t demux_calc_frames_without_wrap_s32(struct cir_buf_sink *sink,
324-
struct cir_buf_source *source,
325-
struct mux_look_up *lookup)
323+
static size_t demux_calc_frames_without_wrap_s32(struct cir_buf_sink *sink,
324+
struct cir_buf_source *source,
325+
struct mux_look_up *lookup)
326326
{
327-
uint32_t frames;
328-
uint32_t min_frames;
327+
size_t frames;
328+
size_t min_frames;
329329
const void *ptr;
330330

331331
/* for demux we process each source buffer separately - dest/src for
@@ -409,15 +409,15 @@ static void demux_init_look_up_pointers_s32(struct sof_sink *sink,
409409
static int demux_s32le(struct comp_dev *dev, struct sof_sink *sink,
410410
struct sof_source *source, const void *source_data,
411411
const void *source_start, size_t source_size,
412-
uint32_t frames, struct mux_look_up *lookup)
412+
size_t frames, struct mux_look_up *lookup)
413413
{
414414
int32_t *y, *y_start, *y_end;
415415
int y_size;
416416
struct cir_buf_sink sink_buf;
417417
struct cir_buf_source source_buf;
418-
int bytes = frames * sink_get_frame_bytes(sink);
418+
size_t bytes = frames * sink_get_frame_bytes(sink);
419419
uint32_t elem;
420-
uint32_t i;
420+
size_t i;
421421
int ret;
422422

423423
comp_dbg(dev, "entry");
@@ -446,7 +446,7 @@ static int demux_s32le(struct comp_dev *dev, struct sof_sink *sink,
446446
lookup->copy_elem[0].in_ch;
447447
int32_t *dst = (int32_t *)lookup->copy_elem[0].dest -
448448
lookup->copy_elem[0].out_ch;
449-
uint32_t frames_without_wrap;
449+
size_t frames_without_wrap;
450450

451451
frames_without_wrap =
452452
demux_calc_frames_without_wrap_s32(&sink_buf, &source_buf, lookup);
@@ -488,14 +488,14 @@ static int demux_s32le(struct comp_dev *dev, struct sof_sink *sink,
488488
*/
489489
static void mux_s32le(struct comp_dev *dev, struct sof_sink *sink,
490490
struct cir_buf_sink *sink_buf, struct sof_source **sources,
491-
struct cir_buf_source *source_bufs, uint32_t frames,
491+
struct cir_buf_source *source_bufs, size_t frames,
492492
struct mux_look_up *lookup)
493493
{
494-
uint32_t i;
494+
size_t i;
495495
const int32_t *src;
496496
int32_t *dst;
497497
uint32_t elem;
498-
uint32_t frames_without_wrap;
498+
size_t frames_without_wrap;
499499

500500
comp_dbg(dev, "entry");
501501

0 commit comments

Comments
 (0)