Skip to content

Commit 91790f3

Browse files
committed
trace: annotate remaining DECLARE_TR_CTX calls
Under Zephyr with CONFIG_ZEPHYR_LOG, tr_err()/tr_warn()/tr_info()/tr_dbg() expand directly to LOG_ERR()/LOG_WRN()/LOG_INF()/LOG_DBG() and never look at their tr_ctx argument. None of these remaining DECLARE_TR_CTX() instances are referenced by anything other than tr_*() calls in the same file (verified: no .tctx/->tctx assignment picks up their address), so they are already dead code eliminated by the linker on Zephyr builds - this commit only documents that fact, it changes no generated code. (dai-legacy.c, host-legacy.c and the platform/library/schedule/*.c files are excluded: they are only ever built for non-Zephyr, non-hardware configurations - testbench/cmocka/legacy XTOS - so the comment would not apply to them.) Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
1 parent 2336e0e commit 91790f3

113 files changed

Lines changed: 117 additions & 0 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/audio/aria/aria.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ SOF_LLEXT_BUILDINFO;
327327

328328
#else
329329

330+
/* unused with Zephyr, generates no output */
330331
DECLARE_TR_CTX(aria_comp_tr, SOF_UUID(aria_uuid), LOG_LEVEL_INFO);
331332
DECLARE_MODULE_ADAPTER(aria_interface, aria_uuid, aria_comp_tr);
332333
SOF_MODULE_INIT(aria, sys_comp_module_aria_interface_init);

‎src/audio/asrc/asrc_ipc3.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
SOF_DEFINE_REG_UUID(asrc);
1818

19+
/* unused with Zephyr, generates no output */
1920
DECLARE_TR_CTX(asrc_tr, SOF_UUID(asrc_uuid), LOG_LEVEL_INFO);
2021
LOG_MODULE_DECLARE(asrc, CONFIG_SOF_LOG_LEVEL);
2122

‎src/audio/asrc/asrc_ipc4.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
SOF_DEFINE_REG_UUID(asrc4);
1818

19+
/* unused with Zephyr, generates no output */
1920
DECLARE_TR_CTX(asrc_tr, SOF_UUID(asrc4_uuid), LOG_LEVEL_INFO);
2021

2122
int asrc_dai_configure_timestamp(struct comp_data *cd)

‎src/audio/buffers/comp_buffer.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
LOG_MODULE_REGISTER(buffer, CONFIG_SOF_LOG_LEVEL);
3030

3131
SOF_DEFINE_REG_UUID(buffer);
32+
/* unused with Zephyr, generates no output */
3233
DECLARE_TR_CTX(buffer_tr, SOF_UUID(buffer_uuid), LOG_LEVEL_INFO);
3334

3435
static size_t comp_buffer_get_data_available(struct sof_source *source)

‎src/audio/buffers/ring_buffer.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
LOG_MODULE_REGISTER(ring_buffer, CONFIG_SOF_LOG_LEVEL);
1919

2020
SOF_DEFINE_REG_UUID(ring_buffer);
21+
/* unused with Zephyr, generates no output */
2122
DECLARE_TR_CTX(ring_buffer_tr, SOF_UUID(ring_buffer_uuid), LOG_LEVEL_INFO);
2223

2324
static inline struct ring_buffer *ring_buffer_from_sink(struct sof_sink *sink)

‎src/audio/channel_map.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ LOG_MODULE_REGISTER(channel_map, CONFIG_SOF_LOG_LEVEL);
1818

1919
SOF_DEFINE_REG_UUID(chmap);
2020

21+
/* unused with Zephyr, generates no output */
2122
DECLARE_TR_CTX(chmap_tr, SOF_UUID(chmap_uuid), LOG_LEVEL_INFO);
2223

2324
struct sof_ipc_channel_map *chmap_get(struct sof_ipc_stream_map *smap,

‎src/audio/codec/dts/dts.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -491,6 +491,7 @@ SOF_LLEXT_BUILDINFO;
491491

492492
#else
493493

494+
/* unused with Zephyr, generates no output */
494495
DECLARE_TR_CTX(dts_tr, SOF_UUID(dts_uuid), LOG_LEVEL_INFO);
495496
DECLARE_MODULE_ADAPTER(dts_interface, dts_uuid, dts_tr);
496497
SOF_MODULE_INIT(dts, sys_comp_module_dts_interface_init);

‎src/audio/component.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ struct comp_driver_list *comp_drivers_get(void)
4848

4949
SOF_DEFINE_REG_UUID(component);
5050

51+
/* unused with Zephyr, generates no output */
5152
DECLARE_TR_CTX(comp_tr, SOF_UUID(component_uuid), LOG_LEVEL_INFO);
5253

5354
int comp_register(struct comp_driver_info *drv)

‎src/audio/copier/copier.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1298,6 +1298,7 @@ static APP_SYSUSER_DATA const struct module_interface copier_interface = {
12981298
.endpoint_ops = &copier_endpoint_ops,
12991299
};
13001300

1301+
/* unused with Zephyr, generates no output */
13011302
DECLARE_TR_CTX(copier_comp_tr, SOF_UUID(copier_uuid), LOG_LEVEL_INFO);
13021303

13031304
DECLARE_MODULE_ADAPTER(copier_interface, copier_uuid, copier_comp_tr);

‎src/audio/crossover/crossover.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -689,6 +689,7 @@ SOF_LLEXT_BUILDINFO;
689689

690690
#else
691691

692+
/* unused with Zephyr, generates no output */
692693
DECLARE_TR_CTX(crossover_tr, SOF_UUID(crossover_uuid), LOG_LEVEL_INFO);
693694
DECLARE_MODULE_ADAPTER(crossover_interface, crossover_uuid, crossover_tr);
694695
SOF_MODULE_INIT(crossover, sys_comp_module_crossover_interface_init);

0 commit comments

Comments
 (0)