ipc4: uaol: add ipc4_find_all_dma_configs_tlvs_only()

This adds yet another function to parse DMA config supplied by the host.
Unfortunately, we now have three functions for this purpose.

Unlike the existing ipc4_find_dma_config(),
ipc4_find_all_dma_configs_tlvs_only() can find multiple DMA configs.
For example, a UAOL copier may use two DMA channels: one for the audio
USB endpoint and one for the feedback USB endpoint.
ipc4_find_all_dma_configs_tlvs_only() can only work when all data in
data_buffer is in TLV format; unfortunately, this is not always the case
with IPC4 for all gateway types. Therefore, the existing
ipc4_find_dma_config() is still needed as it can skip non-TLV blob data
at the beginning of data_buffer.

The other function, ipc4_find_dma_config_multiple(), works differently:
it searches for DMA config for a given ALH stream ID in ALH multi-gateway
case. Hence, this third function -- ipc4_find_all_dma_configs_tlvs_only()
-- is added to the family.

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

Author: serhiy-katsyuba-intel

src/audio/copier/copier_dai.c

@@ -337,7 +337,7 @@ __cold int copier_dai_create(struct comp_dev *dev, struct copier_data *cd,
 		dai.type = SOF_DAI_INTEL_UAOL;
 		dai.is_config_blob = true;
 		cd->gtw_type = ipc4_gtw_alh;
-		ret = ipc4_find_dma_config(&dai, gtw_cfg_data, gtw_cfg_size);
+		ret = ipc4_find_all_dma_configs_tlvs_only(&dai, gtw_cfg_data, gtw_cfg_size);
 		if (ret != IPC4_SUCCESS) {
 			comp_err(dev, "No uaol dma_config found in blob!");
 			return -EINVAL;

src/include/sof/ipc/topology.h

@@ -56,6 +56,8 @@ int ipc4_trigger_chain_dma(struct ipc *ipc, struct ipc4_chain_dma *cdma, bool *d
 int ipc4_process_on_core(uint32_t core, bool blocking);
 int ipc4_pipeline_complete(struct ipc *ipc, uint32_t comp_id, uint32_t cmd);
 int ipc4_find_dma_config(struct ipc_config_dai *dai, uint8_t *data_buffer, uint32_t size);
+int ipc4_find_all_dma_configs_tlvs_only(struct ipc_config_dai *dai,
+					uint8_t *data_buffer, size_t size);
 int ipc4_pipeline_prepare(struct ipc_comp_dev *ppl_icd, uint32_t cmd);
 int ipc4_pipeline_trigger(struct ipc_comp_dev *ppl_icd, uint32_t cmd, bool *delayed);
 int ipc4_find_dma_config_multiple(struct ipc_config_dai *dai, uint8_t *data_buffer,

src/ipc/ipc4/helper.c

@@ -1311,6 +1311,49 @@ int ipc4_find_dma_config(struct ipc_config_dai *dai, uint8_t *data_buffer, uint3
 	return IPC4_SUCCESS;
 }
 
+/* Unlike the above ipc4_find_dma_config(), this can find multiple DMA configs.
+ * For example, a UAOL copier may use two DMA channels: one for audio and one
+ * for clock feedback. This function can only work when all data in data_buffer
+ * is in TLV format; however, this is not always the case for all gateway types.
+ * Therefore, the above ipc4_find_dma_config() is still used as it can skip non-TLV
+ * blob data at the beginning of data_buffer.
+ */
+int ipc4_find_all_dma_configs_tlvs_only(struct ipc_config_dai *dai,
+					uint8_t *data_buffer, size_t size)
+{
+	uintptr_t end_addr = (uintptr_t)data_buffer + size;
+	struct sof_tlv *tlvs;
+	struct ipc_dma_config *dma_cfg;
+	int count = 0;
+
+	for (tlvs = (struct sof_tlv *)data_buffer; tlvs && (uintptr_t)tlvs < end_addr;
+	     tlvs = tlv_next(tlvs)) {
+		if ((uintptr_t)tlvs->value + tlvs->length > end_addr) {
+			tr_err(&ipc_tr, "Unexpected TLV length %d: exceeds buffer size", tlvs->length);
+			return IPC4_INVALID_REQUEST;
+		}
+
+		dma_cfg = tlv_value_ptr_get(tlvs, GTW_DMA_CONFIG_ID);
+		if (!dma_cfg)
+			continue;
+
+		if (count >= GTW_DMA_DEVICE_MAX_COUNT) {
+			tr_err(&ipc_tr, "Unexpected DMA config count %d, max %d",
+			       count, GTW_DMA_DEVICE_MAX_COUNT);
+			return IPC4_INVALID_REQUEST;
+		}
+
+		dai->host_dma_config[count++] = dma_cfg;
+	}
+
+	if (count == 0) {
+		tr_err(&ipc_tr, "No DMA config found");
+		return IPC4_INVALID_REQUEST;
+	}
+
+	return IPC4_SUCCESS;
+}
+
 int ipc4_find_dma_config_multiple(struct ipc_config_dai *dai, uint8_t *data_buffer,
 				  uint32_t size, uint32_t device_id, int dma_cfg_idx)
 {