Skip to content

temporal_workfow_canceled or temporal_workflow_cancelled - docs use double "l" code uses one. #3916

@DonForbes

Description

@DonForbes

Temporal Affiliation

  • I am a Temporal employee

Page URL

https://docs.temporal.io/references/sdk-metrics#workflow_cancelled

Typo or Grammar Issue

The docs specify that the metric name for workflows cancelled is workflow_cancelled however the actual metric that is emitted is workflow_canceled.
eg. The metrics from the java sample

# HELP **temporal_workflow_canceled_total**  
# TYPE **temporal_workflow_canceled_total** counter
**temporal_workflow_canceled_total**{activity_type="none",exception="none",namespace="default",operation="none",query_type="none",signal_name="none",status_code="none",task_queue="metricsqueue",workerCustomTag1="workerCustomTag1Value",workerCustomTag2="workerCustomTag2Value",worker_type="none",workflow_type="MetricsWorkflow",} 1.0

It would be good to have consistency between the code and docs. Either update the docs to show canceled spelled with a single l or add a metric of temporal_workflow_cancelled_total, presumably keeping the current temporal_workflow_canceled_total for backward compatibility....

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions