invalid literal for int() with base 10: '' when omitting role selection

[JonRoma]

If one hits return instead of selecting a role by number, one gets the error message invalid literal for int() with base 10: '', which is programmer-centric but not user-centric. Placing this in a loop with a message stating "Please select a role or enter 'q' to quit" might be more appropriate.

: aws login
Please choose the role you would like to assume:
     Account: 224588347132
         [ 0 ]: ApplicationServicesAdmins
     Account: 378517677616
         [ 1 ]: TechServicesStaff
     Account: 531841101767
         [ 2 ]: ApplicationServicesAdmins
     Account: 617683844790
         [ 3 ]: ApplicationServicesAdmins
     Account: 621331288878
         [ 4 ]: ApplicationServicesAdmins
     Account: 736533337653
         [ 5 ]: ADAdmins
Selection: 
invalid literal for int() with base 10: ''

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[ddriddle]

The 1.0 release resolves this issue. I decided against a loop for simplicity. Instead, a fatal error message is issued: Invalid selection!. So better error message. If this issue bugs you tell me what you prefer and I will strongly consider fixing it!

[JonRoma]

@ddriddle, I think it bad practice to produce a fatal error when interacting with a user, especially if a more helpful prompt can be provided before allowing the end user to correct their error.

The example code below provides a more friendly "try again" approach.

This is a working example and much of the code is boilerplate to take the place of your real account selection logic. Hence much of the example doesn't need to be incorporated into your code. The key logic I propose is limited to the prompt_account function and the code surrounding its invocation inside the main() function.

prompt-example.py.txt

[ddriddle]

@JonRoma I implemented a simple version of this in PR #255. Here is what it looks like in action:

$ aws login
Please choose the role you would like to assume:
     Account: 199050005105
         [ 0 ]: Admins
     Account: 378517677616
         [ 1 ]: TechServicesStaff
     Account: 510155251718
         [ 2 ]: PIE-SharedWP-Team
     Account: 736533337653
         [ 3 ]: ADAdmins
Selection: abc
Invalid value 'abc'. Try again.
Please choose the role you would like to assume:
     Account: 199050005105
         [ 0 ]: Admins
     Account: 378517677616
         [ 1 ]: TechServicesStaff
     Account: 510155251718
         [ 2 ]: PIE-SharedWP-Team
     Account: 736533337653
         [ 3 ]: ADAdmins
Selection: def
Invalid value 'def'. Try again.
Please choose the role you would like to assume:
     Account: 199050005105
         [ 0 ]: Admins
     Account: 378517677616
         [ 1 ]: TechServicesStaff
     Account: 510155251718
         [ 2 ]: PIE-SharedWP-Team
     Account: 736533337653
         [ 3 ]: ADAdmins
Selection: 0
$ 

Tell me what you think. This is a first try. The code is in draft mode for now. Thanks for reopening this PR.