Repository navigation
Commit 2a45fa2
committed
fix(iterate-pr): gate the in-progress check on the author, and bound its wait
Three findings from review, all real.
**A human is not a review bot, and this was the dangerous direction.** The
in-progress check ran on every comment regardless of author, so a person
writing "Review in progress on my end, back by EOD" was filed as an unfinished
review, vanished from `needs_attention`, and hung the wait loop permanently: a
person's comment never gets edited into a finished form the way the bot's
placeholder does, so the count never drops. Gated on `isReviewBot(author)`,
with tests covering the same body from both a human and the bot.
**Two regex edges could each reintroduce the bug.** Leading emphasis was capped
at two characters, so `***Review in progress***` did not match, which is one
format drift from the bold case already anticipated. And the trailing
`(?![A-Za-z0-9])` admitted a bare underscore, so `Review in progress_notes: …`
matched as unfinished. Emphasis is now unbounded, and the trailing side
consumes closing emphasis before refusing a word character including `_`, which
accepts `__…__` and rejects `progress_notes`.
**The wait loop had no escape hatch.** A cancelled run or a crashed job leaves
the placeholder in place with nobody to edit it, and the documented procedure
said only "repeat until it drops to 0". It is now bounded at roughly ten
minutes, and reaching the bound is an "Ask for help" report naming the PR and
the bot, rather than more polling. Waiting forever is the same failure as
exiting early, reached from the other side.1 parent f67adb0 commit 2a45fa2
3 files changed
Lines changed: 77 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
392 | 392 | | |
393 | 393 | | |
394 | 394 | | |
395 | | - | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
396 | 398 | | |
397 | 399 | | |
398 | 400 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
163 | | - | |
164 | | - | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
165 | 173 | | |
166 | 174 | | |
167 | | - | |
168 | | - | |
| 175 | + | |
| 176 | + | |
169 | 177 | | |
170 | 178 | | |
171 | 179 | | |
| |||
257 | 265 | | |
258 | 266 | | |
259 | 267 | | |
260 | | - | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
261 | 275 | | |
262 | 276 | | |
263 | 277 | | |
| |||
Lines changed: 55 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
784 | 784 | | |
785 | 785 | | |
786 | 786 | | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
0 commit comments