feat: show version on dashboard#170
Conversation
DAcodedBEAT
force-pushed
the
version-in-ui
branch
2 times, most recently
from
c88c566 to
034b3f2
Compare
| <h2> | ||
| {{if .IsNew}}Add New OIDC Client{{else}}Edit OIDC Client{{end}} | ||
| </h2> | ||
| <a class="btn btn-secondary" href="/">← Back to Clients</a> |
There was a problem hiding this comment.
it looks like your editor is sorting HTML attributes? Would you mind disabling that, or moving these changes to a different commit (on the same PR is fine), so the actual changes related to showing the version are easier to see?
There was a problem hiding this comment.
Thanks @willnorris - I've amended the changes so the attributes are in the same order as it was previously
There was a problem hiding this comment.
Sorry I missed it on the first round, but there are also a bunch of whitespace only edits: https://github.com/tailscale/tsidp/pull/170/changes?w=0 most notably, server/ui-header.html which has only whitespace edits. I'm imagining these were auto-applied by your editor?
I can also just clean these up after with a full pass with prettier or something. But in general, please try to make sure your PRs just includes the necessary changes, not all the extra formatting. Unless of course the formatting is the intent of the PR 😄 ... we do that occasionally, just to get everything consistent with a defined style.
Display release version in dashboard footer and includes template optimizations for better reuse. Signed-off-by: Arun Philip <arun@corkinc.com>
DAcodedBEAT
force-pushed
the
version-in-ui
branch
from
034b3f2 to
2666810
Compare
2 participants
Display release version in dashboard footer and includes template optimizations for better reuse.
tested by running
go build -o build/tsidp-server-darwin-arm64-$(shell date +%Y-%m-%d)-$(shell git rev-parse --short=5 HEAD) -ldflags "-X github.com/tailscale/tsidp/server.version=v1.2.3" ./tsidp-server.goand going to the appCloses #157