Skip to content

Guest photos missing for guests without GitHub — add X/Twitter photo fallback #2182

@2u841r

Description

@2u841r

The guests page sources all photos from https://github.com/{guest.github}.png. Guests without a GitHub handle get a broken/default image.

12 guests currently missing photos

Guest Twitter fallback available
Dr. Courtney Tolinski drtolinski
Varun Mohan _mohansolo
Taylor Desseyn tdesseyn
Topher Martini tophermartini
Hans Skillrud DeepSpaceHans
Donata Skillrud DonataSkillrud
Syed Balkhi syedbalkhi
Tim Leland TimLeland
Connor Finlayson FinlaysonConnor
Harry Dry harrydry
Loïc Houssier ❌ no twitter either
Anna Poblets ❌ no twitter either

Proposed fix

Fall back to https://unavatar.io/twitter/{guest.twitter} when guest.github is null. Loïc Houssier and Anna Poblets would still need a generic placeholder.

Two small changes needed:

  • Add twitter to the guest select in src/routes/(site)/guests/+page.server.ts
  • Update the <img src> logic in src/routes/(site)/guests/+page.svelte to use the fallback

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions