Skip to content

Commit d78cc7f

Browse files
committed
refactor: extract reusable dimen constant
1 parent a95166a commit d78cc7f

3 files changed

Lines changed: 15 additions & 8 deletions

File tree

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
package to.bitkit.appwidget.ui.components
2+
3+
import androidx.compose.ui.unit.DpSize
4+
import androidx.compose.ui.unit.dp
5+
6+
object GlanceLayoutDimens {
7+
val WIDE_LAYOUT_MIN_WIDTH = 280.dp
8+
9+
val COMPACT_WIDGET_SIZE = DpSize(163.dp, 192.dp)
10+
val WIDE_WIDGET_SIZE = DpSize(343.dp, 152.dp)
11+
}

app/src/main/java/to/bitkit/appwidget/ui/price/PriceGlanceContent.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,12 @@ import to.bitkit.appwidget.ui.components.CaptionB
3232
import to.bitkit.appwidget.ui.components.GlanceWidgetScaffold
3333
import to.bitkit.appwidget.ui.components.HorizontalSpacer
3434
import to.bitkit.appwidget.ui.components.VerticalSpacer
35+
import to.bitkit.appwidget.ui.components.GlanceLayoutDimens
3536
import to.bitkit.appwidget.ui.theme.GlanceTextStyles
3637
import to.bitkit.data.dto.price.GraphPeriod
3738
import to.bitkit.data.dto.price.PriceWidgetData
3839
import to.bitkit.ui.theme.Colors
3940

40-
private val WIDE_LAYOUT_MIN_WIDTH = 280.dp
41-
4241
@Suppress("RestrictedApi")
4342
@Composable
4443
fun PriceGlanceContent(
@@ -60,7 +59,7 @@ fun PriceGlanceContent(
6059
return@GlanceWidgetScaffold
6160
}
6261

63-
if (LocalSize.current.width >= WIDE_LAYOUT_MIN_WIDTH) {
62+
if (LocalSize.current.width >= GlanceLayoutDimens.WIDE_LAYOUT_MIN_WIDTH) {
6463
WideContent(widget = widget, chartBitmap = chartBitmap)
6564
} else {
6665
CompactContent(widget = widget, chartBitmap = chartBitmap)

app/src/main/java/to/bitkit/appwidget/ui/price/PriceGlanceWidget.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ import androidx.compose.runtime.collectAsState
66
import androidx.compose.runtime.getValue
77
import androidx.compose.runtime.remember
88
import androidx.compose.ui.graphics.toArgb
9-
import androidx.compose.ui.unit.DpSize
10-
import androidx.compose.ui.unit.dp
119
import androidx.glance.GlanceId
1210
import androidx.glance.appwidget.GlanceAppWidget
1311
import androidx.glance.appwidget.GlanceAppWidgetManager
@@ -18,6 +16,7 @@ import to.bitkit.appwidget.AppWidgetEntryPoint
1816
import to.bitkit.appwidget.model.AppWidgetData
1917
import to.bitkit.appwidget.model.AppWidgetEntry
2018
import to.bitkit.appwidget.model.AppWidgetType
19+
import to.bitkit.appwidget.ui.components.GlanceLayoutDimens
2120
import to.bitkit.data.dto.price.PriceDTO
2221
import to.bitkit.data.dto.price.PriceWidgetData
2322
import to.bitkit.ui.theme.Colors
@@ -27,12 +26,10 @@ class PriceGlanceWidget : GlanceAppWidget() {
2726
companion object {
2827
private const val CHART_WIDTH = 600
2928
private const val CHART_HEIGHT = 200
30-
val COMPACT = DpSize(163.dp, 192.dp)
31-
val WIDE = DpSize(343.dp, 152.dp)
3229
}
3330

3431
override val sizeMode = SizeMode.Responsive(
35-
setOf(COMPACT, WIDE),
32+
setOf(GlanceLayoutDimens.COMPACT_WIDGET_SIZE, GlanceLayoutDimens.WIDE_WIDGET_SIZE),
3633
)
3734

3835
override suspend fun provideGlance(context: Context, id: GlanceId) {

0 commit comments

Comments
 (0)