Skip to content

Commit 93e981c

Browse files
committed
fix: address claude review nits
1 parent a787832 commit 93e981c

4 files changed

Lines changed: 11 additions & 11 deletions

File tree

app/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ fun ProfileEditForm(
155155
painter = painterResource(R.drawable.ic_pencil_simple),
156156
contentDescription = null,
157157
tint = Colors.White64,
158-
modifier = Modifier.size(16.dp),
158+
modifier = Modifier.size(16.dp)
159159
)
160160
IconButton(onClick = { onRemoveLink(index) }) {
161161
Icon(
@@ -195,7 +195,7 @@ fun ProfileEditForm(
195195
modifier = Modifier.size(16.dp)
196196
)
197197
},
198-
modifier = Modifier.testTag("ProfileEditAddLink"),
198+
modifier = Modifier.testTag("ProfileEditAddLink")
199199
)
200200
}
201201

@@ -237,7 +237,7 @@ fun ProfileEditForm(
237237
modifier = Modifier.size(16.dp)
238238
)
239239
},
240-
modifier = Modifier.testTag("ProfileEditAddTag"),
240+
modifier = Modifier.testTag("ProfileEditAddTag")
241241
)
242242
}
243243

app/src/main/java/to/bitkit/ui/components/Tag.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ fun TagButton(
5050
color = textColor,
5151
maxLines = 1,
5252
overflow = TextOverflow.Ellipsis,
53-
modifier = Modifier.testTag("Tag-$text"),
53+
modifier = Modifier.testTag("Tag-$text")
5454
)
5555

5656
if (displayIconClose) {

app/src/test/java/to/bitkit/ui/WalletViewModelTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import kotlinx.coroutines.ExperimentalCoroutinesApi
55
import kotlinx.coroutines.flow.MutableStateFlow
66
import kotlinx.coroutines.runBlocking
77
import kotlinx.coroutines.test.advanceUntilIdle
8-
import org.junit.Assert.assertEquals
98
import org.junit.Before
109
import org.junit.Test
1110
import org.lightningdevkit.ldknode.PeerDetails
@@ -33,6 +32,7 @@ import to.bitkit.services.MigrationService
3332
import to.bitkit.test.BaseUnitTest
3433
import to.bitkit.viewmodels.RestoreState
3534
import to.bitkit.viewmodels.WalletViewModel
35+
import kotlin.test.assertEquals
3636

3737
@OptIn(ExperimentalCoroutinesApi::class)
3838
class WalletViewModelTest : BaseUnitTest() {
@@ -62,7 +62,7 @@ class WalletViewModelTest : BaseUnitTest() {
6262
whenever(migrationService.isMigrationChecked()).thenReturn(true)
6363
whenever(migrationService.isChannelRecoveryChecked()).thenReturn(true)
6464
whenever(migrationService.tryFetchMigrationPeersFromBackup()).thenReturn(emptyList())
65-
whenever(migrationService.getRNRemoteBackupTimestamp()).thenReturn(null)
65+
whenever { migrationService.getRNRemoteBackupTimestamp() }.thenReturn(null)
6666
whenever(connectivityRepo.isOnline).thenReturn(isOnline)
6767

6868
sut = WalletViewModel(

app/src/test/java/to/bitkit/ui/screens/contacts/ContactImportFlowTest.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ import kotlin.test.assertEquals
77
import kotlin.test.assertNull
88

99
class ContactImportFlowTest {
10+
private companion object {
11+
const val VALID_PUBLIC_KEY = "pubkyybndrfg8ejkmcpqxot1uwisza345h769ybndrfg8ejkmcpqxot1u"
12+
const val OTHER_VALID_PUBLIC_KEY = "pubkya345h769ybndrfg8ejkmcpqxot1uwiszybndrfg8ejkmcpqxot1u"
13+
}
14+
1015
@Test
1116
fun `resolveAddContactValidation returns empty for blank input`() {
1217
assertEquals(
@@ -87,9 +92,4 @@ class ContactImportFlowTest {
8792
),
8893
)
8994
}
90-
91-
private companion object {
92-
const val VALID_PUBLIC_KEY = "pubkyybndrfg8ejkmcpqxot1uwisza345h769ybndrfg8ejkmcpqxot1u"
93-
const val OTHER_VALID_PUBLIC_KEY = "pubkya345h769ybndrfg8ejkmcpqxot1uwiszybndrfg8ejkmcpqxot1u"
94-
}
9595
}

0 commit comments

Comments
 (0)