Skip to content

Commit 733dec3

Browse files
committed
fix: contact delete toast, ContactDeletedToast, and yes delete on detail
Made-with: Cursor
1 parent 89aa453 commit 733dec3

4 files changed

Lines changed: 12 additions & 1 deletion

File tree

app/src/main/java/to/bitkit/ui/screens/contacts/ContactDetailScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ private fun Content(
126126
AppAlertDialog(
127127
title = stringResource(R.string.contacts__delete_confirm_title, currentProfile.name),
128128
text = stringResource(R.string.contacts__delete_confirm_text, currentProfile.name),
129-
confirmText = stringResource(R.string.contacts__delete_contact),
129+
confirmText = stringResource(R.string.common__delete_yes),
130130
onConfirm = onConfirmDelete,
131131
onDismiss = onDismissDeleteDialog,
132132
)

app/src/main/java/to/bitkit/ui/screens/contacts/ContactDetailViewModel.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,11 @@ class ContactDetailViewModel @Inject constructor(
145145
_uiState.update { it.copy(showDeleteDialog = false) }
146146
pubkyRepo.removeContact(publicKey)
147147
.onSuccess {
148+
ToastEventBus.send(
149+
type = Toast.ToastType.SUCCESS,
150+
title = context.getString(R.string.contacts__delete_success),
151+
testTag = "ContactDeletedToast",
152+
)
148153
_effects.emit(ContactDetailEffect.DeleteSuccess)
149154
}
150155
.onFailure {

app/src/main/java/to/bitkit/ui/screens/contacts/EditContactViewModel.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,11 @@ class EditContactViewModel @Inject constructor(
213213
_uiState.update { it.copy(showDeleteDialog = false, isSaving = true) }
214214
pubkyRepo.removeContact(publicKey)
215215
.onSuccess {
216+
ToastEventBus.send(
217+
type = Toast.ToastType.SUCCESS,
218+
title = context.getString(R.string.contacts__delete_success),
219+
testTag = "ContactDeletedToast",
220+
)
216221
_effects.emit(EditContactEffect.DeleteSuccess)
217222
}
218223
.onFailure {

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@
8787
<string name="contacts__delete_confirm_text">Are you sure you want to delete %1$s from your contacts?</string>
8888
<string name="contacts__delete_confirm_title">Delete %1$s?</string>
8989
<string name="contacts__delete_contact">Delete Contact</string>
90+
<string name="contacts__delete_success">Contact deleted</string>
9091
<string name="contacts__detail_empty_state">Unable to load contact.</string>
9192
<string name="contacts__detail_title">Contact</string>
9293
<string name="contacts__edit_bio_placeholder">Short note about this contact.</string>

0 commit comments

Comments
 (0)