Merge pull request #725 from synonymdev/fix/default-invoice-description

fix: remove default invoice description

Author: ovitrif

README.md

@@ -153,6 +153,16 @@ To build the mainnet flavor for release run:
 ./gradlew assembleMainnetRelease
 ```
 
+#### Android App Bundle (AAB)
+
+For Play Store submission, build an AAB instead of APK:
+
+```sh
+./gradlew bundleMainnetRelease
+```
+
+AAB is generated in `app/build/outputs/bundle/mainnetRelease/`.
+
 ### Build for E2E Testing
 
 Pass `E2E=true` and build any flavor. By default, E2E uses a local Electrum override.

app/src/main/java/to/bitkit/env/Env.kt

@@ -43,7 +43,6 @@ internal object Env {
 
     const val FILE_PROVIDER_AUTHORITY = "${BuildConfig.APPLICATION_ID}.fileprovider"
     const val SUPPORT_EMAIL = "support@synonym.to"
-    const val DEFAULT_INVOICE_MESSAGE = "Bitkit"
     const val PIN_LENGTH = 4
     const val PIN_ATTEMPTS = 8
 

app/src/main/java/to/bitkit/repositories/BlocktankRepo.kt

@@ -195,7 +195,7 @@ class BlocktankRepo @Inject constructor(
 
     suspend fun createCjit(
         amountSats: ULong,
-        description: String = Env.DEFAULT_INVOICE_MESSAGE,
+        description: String = "",
     ): Result<IcJitEntry> = withContext(bgDispatcher) {
         runCatching {
             if (coreService.isGeoBlocked()) throw ServiceError.GeoBlocked()

app/src/main/java/to/bitkit/repositories/WalletRepo.kt

@@ -270,7 +270,7 @@ class WalletRepo @Inject constructor(
         val newBip21 = buildBip21Url(
             bitcoinAddress = address,
             amountSats = amountSats,
-            message = message.ifBlank { Env.DEFAULT_INVOICE_MESSAGE },
+            message = message,
             lightningInvoice = getBolt11(),
         )
         setBip21(newBip21)
@@ -386,7 +386,7 @@ class WalletRepo @Inject constructor(
     fun buildBip21Url(
         bitcoinAddress: String,
         amountSats: ULong? = null,
-        message: String = Env.DEFAULT_INVOICE_MESSAGE,
+        message: String = "",
         lightningInvoice: String = "",
     ): String {
         return Bip21Utils.buildBip21Url(

app/src/main/java/to/bitkit/services/LightningService.kt

@@ -467,7 +467,7 @@ class LightningService @Inject constructor(
     suspend fun receive(sat: ULong? = null, description: String, expirySecs: UInt = 3600u): String {
         val node = this.node ?: throw ServiceError.NodeNotSetup()
 
-        val message = description.ifBlank { Env.DEFAULT_INVOICE_MESSAGE }
+        val message = description
 
         return ServiceQueue.LDK.background {
             val bolt11Invoice: Bolt11Invoice = if (sat != null) {

app/src/main/res/values-cs/strings.xml

@@ -720,8 +720,6 @@
     <string name="settings__widgets__nav_title">Widgety</string>
     <string name="settings__widgets__showWidgetTitles">Zobrazit názvy widgetů</string>
     <string name="settings__widgets__showWidgets">Widgety</string>
-    <string name="slashtags__auth_depricated_msg">Slashauth je zastaralý. Používejte prosím Bitkit Beta.</string>
-    <string name="slashtags__auth_depricated_title">Nedoporučený</string>
     <string name="slashtags__onboarding_profile1_header">Vlastněte svůj\n&lt;accent&gt;profil&lt;/accent&gt;</string>
     <string name="slashtags__onboarding_profile1_text">Nastavte si veřejný profil a odkazy, aby vás kontakty ze služby Bitkit mohly kdykoli a kdekoli kontaktovat nebo vám zaplatit.</string>
     <string name="slashtags__profile">Profil</string>

app/src/main/res/values-de/strings.xml

@@ -756,8 +756,6 @@
     <string name="slashtags__onboarding_profile1_text">Richte dein öffentliches Profil und Links ein, damit deine Bitkit-Kontakte dich erreichen oder bezahlen können, jederzeit und überall.</string>
     <string name="slashtags__profile">Profil</string>
     <string name="slashtags__profile_create">Profil erstellen</string>
-    <string name="slashtags__auth_depricated_title">Abgelehnt</string>
-    <string name="slashtags__auth_depricated_msg">Slashauth ist veraltet. Bitte verwenden Sie Bitkit Beta.</string>
     <string name="wallet__drawer__wallet">Wallet</string>
     <string name="wallet__drawer__activity">Aktivität</string>
     <string name="wallet__drawer__contacts">Kontakte</string>

app/src/main/res/values-es/strings.xml

@@ -460,7 +460,6 @@
     <string name="security__pin_security_header">Aumentar la seguridad</string>
     <string name="security__pin_security_title">Protege\ntus bitcoin</string>
     <string name="security__pin_security_text">Para mejorar la seguridad del monedero, puede establecer un código PIN y Face ID.</string>
-    <string name="security__pin_security_title__styled">&lt;accent&gt;Protege&lt;/accent&gt;\ntu bitcoin</string>
     <string name="security__pin_security_button">Proteger Monedero</string>
     <string name="security__pin_send_title">Introducir Código PIN</string>
     <string name="security__pin_choose_header">Elija un PIN de 4 dígitos</string>
@@ -654,7 +653,6 @@
     <string name="settings__adv__section_payments">Pagos</string>
     <string name="settings__adv__section_networks">Redes</string>
     <string name="settings__adv__section_other">Otros</string>
-    <string name="settings__adv__section_quickpay">QuickPay</string>
     <string name="settings__adv__coin_selection">Selección de monedas</string>
     <string name="settings__adv__cs_method">Método de selección de monedas</string>
     <string name="settings__adv__cs_manual">Manual</string>
@@ -670,7 +668,6 @@
     <string name="settings__adv__cs_max_description">Usa los UTXOs de mayor valor primero</string>
     <string name="settings__adv__cs_min">Minimizar</string>
     <string name="settings__adv__cs_min_description">Usa los UTXOs de menor valor primero</string>
-    <string name="settings__adv__notifications">Pagos en Segundo Plano</string>
     <string name="settings__adv__address_viewer">Visualizador de direcciones</string>
     <string name="settings__adv__suggestions_reset">Restablecer sugerencias</string>
     <string name="settings__adv__reset_title">¿Restablecer sugerencias?</string>
@@ -680,12 +677,6 @@
     <string name="settings__adv__lightning_node">Nodo Lightning</string>
     <string name="settings__adv__electrum_server">Servidor Electrum</string>
     <string name="settings__adv__rgs_server">Rapid-Gossip-Sync</string>
-    <string name="settings__adv__quickpay">QuickPay</string>
-    <string name="settings__adv__quickpay_desc">Paga facturas Lightning automáticamente sin confirmar</string>
-    <string name="settings__adv__quickpay_max_title">Límite Máximo de QuickPay</string>
-    <string name="settings__adv__quickpay_max_value">Establecer en {amount}</string>
-    <string name="settings__adv__quickpay_switch">Paga facturas hasta {amount}</string>
-    <string name="settings__adv__save_scanned_addresses">Guardar direcciones escaneadas y cargadas</string>
     <string name="settings__fee__fast__label">Rápido (más caro)</string>
     <string name="settings__fee__fast__value">Rápido</string>
     <string name="settings__fee__fast__description">± 10-20 minutos</string>
@@ -705,7 +696,6 @@
     <string name="settings__addr__addr_change">Cambiar direcciones</string>
     <string name="settings__addr__addr_receiving">Direcciones de recepción</string>
     <string name="settings__addr__gen_20">Generar 20 más</string>
-    <string name="settings__addr__gen_20_max">Máximo de direcciones generadas</string>
     <string name="settings__addr__no_addrs_str">Sin direcciones</string>
     <string name="settings__addr__spend_number">Gastar ({count}) direcciones seleccionadas</string>
     <string name="settings__addr__check_balances">Consultar Saldos</string>
@@ -728,24 +718,12 @@
     <string name="settings__es__server_error_description">Bitkit no pudo conectarse al servidor Electrum especificado.</string>
     <string name="settings__rgs__server_url">URL del Servidor Rapid-Gossip-Sync</string>
     <string name="settings__rgs__button_connect">Conectar</string>
-    <string name="settings__rgs__button_reset">Restablecer valores predeterminados</string>
-    <string name="settings__rgs__update_success_message">Conexión exitosa a {url}</string>
     <string name="settings__rgs__update_success_description">Bitkit se ha conectado correctamente al servidor Rapid-Gossip-Sync especificado.</string>
     <string name="settings__rgs__update_success_title">Servidor Rapid-Gossip-Sync Actualizado</string>
-    <string name="slashtags__contact_add_error">No se Puede Añadir Contacto</string>
-    <string name="slashtags__contact_add_error_msg">Por favor, comprueba si el código QR es una clave de contacto válida.</string>
-    <string name="slashtags__contact_delete_error_description">Bitkit no pudo eliminar el contacto.</string>
-    <string name="slashtags__contact_delete_error_title">Eliminación de Contacto Fallida</string>
-    <string name="slashtags__contact_edit_error">Error al Editar Contacto</string>
-    <string name="slashtags__contact_edit_error_description">Bitkit no pudo guardar la información del contacto.</string>
-    <string name="slashtags__edit_error">Bitkit no pudo guardar tu perfil.</string>
-    <string name="slashtags__edit_error_title">Guardado de Perfil Fallido</string>
     <string name="slashtags__onboarding_profile1_text">Configura tu perfil público y enlaces para que tus contactos Bitkit puedan localizarte o pagarte en cualquier momento y lugar.</string>
     <string name="slashtags__onboarding_profile1_header">Configura tu\n&lt;accent&gt;perfil público&lt;/accent&gt;</string>
     <string name="slashtags__profile">Perfil</string>
     <string name="slashtags__profile_create">Crear perfil</string>
-    <string name="slashtags__profile_delete_dialogue">¿Estás seguro de que quieres eliminar este enlace de tu perfil?</string>
-    <string name="slashtags__profile_key">Clave de perfil</string>
     <string name="sweep__balance_format">Saldo: {balance}</string>
     <string name="sweep__checking_description">Por favor espera mientras Bitkit comprueba si hay fondos en esta dirección.</string>
     <string name="sweep__checking_loading">Comprobando si hay fondos...</string>
@@ -778,10 +756,6 @@
     <string name="sweep__total">Total</string>
     <string name="sweep__utxo_format">{count, plural, one {# UTXO} other {# UTXOs}}</string>
     <string name="sweep__utxos_format">{count, plural, one {# UTXO seleccionado} other {# UTXOs seleccionados}}</string>
-    <string name="time__days">{count, plural, one {# día} other {# días}}</string>
-    <string name="time__hours">{count, plural, one {# hora} other {# horas}}</string>
-    <string name="time__minutes">{count, plural, one {# minuto} other {# minutos}}</string>
-    <string name="time__seconds">{count, plural, one {# segundo} other {# segundos}}</string>
     <string name="wallet__drawer__activity">Actividad</string>
     <string name="wallet__drawer__contacts">Contactos</string>
     <string name="wallet__drawer__profile">Perfil</string>

app/src/main/res/values-fr/strings.xml

@@ -724,8 +724,6 @@
     <string name="slashtags__onboarding_profile1_text">Configurez votre profil public et vos liens, afin que vos contacts Bitkit puissent vous joindre ou vous payer à tout moment et en tout lieu.</string>
     <string name="slashtags__profile">Profil</string>
     <string name="slashtags__profile_create">Créer un profil</string>
-    <string name="slashtags__auth_depricated_title">Déclassé</string>
-    <string name="slashtags__auth_depricated_msg">Slashauth est obsolète. Veuillez utiliser Bitkit Beta.</string>
     <string name="sweep__balance_format">%1$s sats</string>
     <string name="sweep__checking_description">Veuillez patienter pendant que Bitkit recherche des fonds dans les adresses non prises en charge (Legacy, Nested SegWit et Taproot).</string>
     <string name="sweep__checking_loading">RECHERCHE DE FONDS...</string>

app/src/main/res/values-pl/strings.xml

@@ -756,8 +756,6 @@
     <string name="sweep__total">Razem</string>
     <string name="sweep__utxo_format">%1$s, %2$d UTXO</string>
     <string name="sweep__utxos_format">%1$s, %2$d UTXOs</string>
-    <string name="slashtags__auth_depricated_title">Przestarzałe</string>
-    <string name="slashtags__auth_depricated_msg">Slashauth jest przestarzałe. Proszę używać Bitkit Beta.</string>
     <string name="wallet__drawer__wallet">Portfel</string>
     <string name="wallet__drawer__activity">Aktywność</string>
     <string name="wallet__drawer__contacts">Kontakty</string>