fix: address PR review - clean up Logger calls

Co-authored-by: Ovi Trif <ovitrif@users.noreply.github.com>

Author: 2 people

AGENTS.md

@@ -178,6 +178,7 @@ suspend fun getData(): Result<Data> = withContext(Dispatchers.IO) {
 - NEVER use `runBlocking` in suspend functions
 - ALWAYS pass the TAG as context to `Logger` calls, e.g. `Logger.debug("message", context = TAG)`
 - NEVER add `e = ` named parameter to Logger calls
+- NEVER manually append the `Throwable`'s message or any other props to the string passed as the 1st param of `Logger.*` calls, its internals are already enriching the final log message with the details of the `Throwable` passed via the `e` arg
 - ALWAYS log errors at the final handling layer where the error is acted upon, not in intermediate layers that just propagate it
 - ALWAYS use the Result API instead of try-catch
 - NEVER wrap methods returning `Result<T>` in try-catch
@@ -221,4 +222,4 @@ suspend fun getData(): Result<Data> = withContext(Dispatchers.IO) {
 - Use `LightningRepo` to defining the business logic for the node operations, usually delegating to `LightningService`
 - Use `WakeNodeWorker` to manage the handling of remote notifications received via cloud messages
 - Use `*Services` to wrap rust library code exposed via bindings
-- Use CQRS pattern of Command + Handler like it's done in the `NotifyPaymentReceived` + `NotifyPaymentReceivedHandler` setup 
+- Use CQRS pattern of Command + Handler like it's done in the `NotifyPaymentReceived` + `NotifyPaymentReceivedHandler` setup

app/src/main/java/to/bitkit/repositories/BlocktankRepo.kt

@@ -425,13 +425,7 @@ class BlocktankRepo @Inject constructor(
     ): Result<GiftClaimResult> = withContext(bgDispatcher) {
         runCatching {
             require(code.isNotBlank()) { "Gift code cannot be blank" }
-
-            if (amount == 0uL) {
-                Logger.warn(
-                    "Gift amount is 0 - proceeding anyway as backend may provide actual amount",
-                    context = TAG
-                )
-            }
+            require(amount > 0u) { "Gift amount must be positive" }
 
             Logger.debug("Starting gift code claim: amount=$amount, timeout=$waitTimeout", context = TAG)
 
@@ -449,20 +443,16 @@ class BlocktankRepo @Inject constructor(
                     context = TAG
                 )
 
-                if (amount > 0uL && maxInboundCapacity >= amount) {
+                if (maxInboundCapacity >= amount) {
                     Logger.debug("Sufficient liquidity available, claiming with existing channel", context = TAG)
                     Result.success(claimGiftCodeWithLiquidity(code))
                 } else {
-                    if (amount == 0uL) {
-                        Logger.debug("Amount unknown (0), defaulting to channel opening path", context = TAG)
-                    } else {
-                        Logger.debug("Insufficient liquidity, opening new channel", context = TAG)
-                    }
+                    Logger.debug("Insufficient liquidity, opening new channel", context = TAG)
                     Result.success(claimGiftCodeWithoutLiquidity(code, amount))
                 }
             }.getOrThrow()
         }.onFailure {
-            Logger.error("Failed to claim gift code: ${it.message}", it, context = TAG)
+            Logger.error("Failed to claim gift code", it, context = TAG)
         }
     }
 

app/src/main/java/to/bitkit/ui/sheets/GiftViewModel.kt

@@ -53,11 +53,6 @@ class GiftViewModel @Inject constructor(
         }
         this.code = code
         this.amount = amount
-
-        if (amount == 0uL) {
-            Logger.warn("Gift amount is 0 from QR code - this may be incorrect", context = TAG)
-        }
-
         viewModelScope.launch(bgDispatcher) {
             claimGift()
         }
@@ -123,14 +118,7 @@ class GiftViewModel @Inject constructor(
     }
 
     private suspend fun handleGiftClaimError(error: Throwable) {
-        val errorMessage = buildString {
-            append("Gift claim failed: ")
-            append(error.message ?: error.toString())
-            error.cause?.let {
-                append(" (cause: ${it.message ?: it})")
-            }
-        }
-        Logger.error(errorMessage, error, context = TAG)
+        Logger.error("Gift claim failed", error, context = TAG)
 
         val route = when {
             errorContains(error, "GIFT_CODE_ALREADY_USED") -> {
@@ -142,7 +130,7 @@ class GiftViewModel @Inject constructor(
                 GiftRoute.UsedUp
             }
             else -> {
-                Logger.error("Unhandled gift claim error type: ${error::class.simpleName}", context = TAG)
+                Logger.error("Unhandled gift claim error type", error, context = TAG)
                 GiftRoute.Error
             }
         }