Skip to content

Declare the products that Test Support and the test target literally import #5

Description

@coenttb

Problem

Two targets use modules their manifest entries do not declare:

  • Tests/Support/exports.swift (Array Primitives Test Support) contains @_exported public import Affine_Primitives_Test_Support and @_exported public import Ordinal_Primitives_Test_Support. The target declares only Array Primitives and Buffer Primitives Test Support. swift-affine-primitives is absent from the package dependencies: entirely; swift-ordinal-primitives is present but its Test Support product is not declared on the target.
  • Tests/Array Primitives Tests/Array Surface Tests.swift imports Buffer_Linear_Bounded_Primitives, which is not declared on the Array Primitives Tests test target (nor reachable from a declared product of this target).

These currently resolve only transitively, so target compilation depends on the internal dependency shape of other packages. Composition doctrine: every module a target's source literally imports is declared as a .product on that target — under-declared means add the product, not remove the import.

Proposed outcome

Package.swift declares the missing package dependency and products on the two targets, and a full build reports no missing-module failure and no unused-dependency warning for the added entries.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions