{join(stays, installation.data?.local_only && installation.data.public_url ? t("Other machines can't reach this installation's public URL, {{url}}, so no uninstall command can be given.", { url: installation.data.public_url }) - : t("An uninstall command needs an HTTPS public URL that other machines can reach, and this installation has none."))}
+ : allowInsecure + ? t("An uninstall command needs a public URL that other machines can reach, and this installation has none.") + : t("An uninstall command needs an HTTPS public URL that other machines can reach, and this installation has none."))}{t("{{name}} is removed from Core. To remove its service and files from the host, run:", { name: cleanup.name })}
{t("Plaintext HTTP: allow_insecure_origin is on, so the enrollment token and the node's credentials travel unencrypted. Use this only on a trusted network.")}
: null} {!available ?{t("This console serves no node installer. For a console deployed by hand, point OAC_WEB_NODE_PAYLOAD_DIR at the distribution's node payload and restart it.")}
: !enrollment && blocker ? blocker.failed ?{blocker.text}
diff --git a/apps/web/src/features/sandbox/SandboxManagerView.css b/apps/web/src/features/sandbox/SandboxManagerView.css index 27b0ad8c..b7cc309f 100644 --- a/apps/web/src/features/sandbox/SandboxManagerView.css +++ b/apps/web/src/features/sandbox/SandboxManagerView.css @@ -11,6 +11,15 @@ .sandbox-summary dt { font-size: 12px; color: var(--ink-3); margin-bottom: 4px; } .sandbox-summary dd { margin: 0; color: var(--ink); font-size: 13px; overflow-wrap: anywhere; } .sandbox-error { color: var(--danger) !important; } +/* A development installation with allow_insecure_origin: the command is plain HTTP. */ +.sandbox-insecure-origin { + padding: 10px 12px; + color: var(--fg) !important; + font-size: 12.5px; + background: color-mix(in srgb, var(--warning) 9%, var(--surface)); + border: 1px solid color-mix(in srgb, var(--warning) 26%, var(--line)); + border-radius: 8px; +} .sandbox-empty { display: grid; justify-items: center; gap: 12px; text-align: center; border: 1px dashed var(--line); border-radius: 12px; padding: 56px 24px; color: var(--fg-muted); } .sandbox-empty h3 { color: var(--fg); font-size: 16px; margin: 0; font-weight: 500; } .sandbox-empty p { max-width: 320px; font-size: 13px; } diff --git a/apps/web/src/features/sandbox/core-origin.test.ts b/apps/web/src/features/sandbox/core-origin.test.ts index d6806825..c126cba6 100644 --- a/apps/web/src/features/sandbox/core-origin.test.ts +++ b/apps/web/src/features/sandbox/core-origin.test.ts @@ -1,5 +1,6 @@ +import type { CoreInstallationSetting } from "@oac/agents-client"; import { describe, expect, it } from "vitest"; -import { httpsOrigin, nodeSourceUrl } from "./core-origin"; +import { allowsInsecureOrigin, httpsOrigin, nodeSourceUrl } from "./core-origin"; describe("HTTPS origin", () => { it.each([ @@ -17,4 +18,30 @@ describe("node command source", () => { expect(nodeSourceUrl({ public_url: null, local_only: false })).toBeNull(); expect(nodeSourceUrl({ public_url: "http://core.example.com", local_only: false })).toBeNull(); }); + it("takes a non-loopback HTTP public URL only when allow_insecure_origin is on", () => { + expect(nodeSourceUrl({ public_url: "http://10.0.0.5:8080", local_only: false }, true)).toBe("http://10.0.0.5:8080"); + // The switch never makes a loopback address reachable from another machine. + expect(nodeSourceUrl({ public_url: "http://127.0.0.1:8091", local_only: true }, true)).toBeNull(); + // A path, credentials or a query are not an origin, switch or not. + expect(nodeSourceUrl({ public_url: "http://10.0.0.5:8080/v1", local_only: false }, true)).toBeNull(); + expect(nodeSourceUrl({ public_url: "http://user:secret@10.0.0.5:8080", local_only: false }, true)).toBeNull(); + }); +}); + +describe("the allow_insecure_origin switch", () => { + const setting = (key: string, value: unknown): CoreInstallationSetting => ({ key, value, default: false, changeable: true, sensitive: false, restarts: ["core"] }); + const installation = (settings: CoreInstallationSetting[] | null) => ({ + configuration: settings === null ? null : { path: "/opt/oac/config.json", apply_command: "sudo oac apply", applied_at: "2026-01-01T00:00:00Z", settings }, + }); + it("reads Core's settings snapshot", () => { + expect(allowsInsecureOrigin(installation([setting("allow_insecure_origin", true)]))).toBe(true); + expect(allowsInsecureOrigin(installation([setting("allow_insecure_origin", false)]))).toBe(false); + }); + it("is off when the snapshot lacks it or there is none", () => { + expect(allowsInsecureOrigin(installation([setting("public_url", "https://core.example")]))).toBe(false); + // Only a literal true turns it on; any other value reads as off. + expect(allowsInsecureOrigin(installation([setting("allow_insecure_origin", "true")]))).toBe(false); + expect(allowsInsecureOrigin(installation(null))).toBe(false); + expect(allowsInsecureOrigin(undefined)).toBe(false); + }); }); diff --git a/apps/web/src/features/sandbox/core-origin.ts b/apps/web/src/features/sandbox/core-origin.ts index 091a2705..12c2a789 100644 --- a/apps/web/src/features/sandbox/core-origin.ts +++ b/apps/web/src/features/sandbox/core-origin.ts @@ -3,14 +3,22 @@ import type { CoreInstallation } from "@oac/agents-client"; import { isValidDirectCoreBaseUrl } from "../../lib/connection"; /** - * The value itself when it is an HTTPS origin: no path, query, fragment or - * credentials; a single trailing slash is dropped. Otherwise null. It is kept - * as written, not normalized, so an explicit port such as :443 stays exactly - * as Core reports it. + * The value itself when it is an origin the node commands may use directly: no + * path, query, fragment or credentials; a single trailing slash is dropped. It + * is kept as written, not normalized, so an explicit port such as :443 stays + * exactly as Core reports it. HTTPS always qualifies; plain HTTP only on a + * loopback host, or on any host when `allowInsecure` is set (a development + * installation with `allow_insecure_origin`). */ -export function httpsOrigin(value: string): string | null { +function origin(value: string, allowInsecure: boolean): string | null { const candidate = value.trim().replace(/\/$/, ""); - return /^https:\/\/[^/?#\\\s@]+$/i.test(candidate) && isValidDirectCoreBaseUrl(candidate) ? candidate : null; + const pattern = allowInsecure ? /^https?:\/\/[^/?#\\\s@]+$/i : /^https:\/\/[^/?#\\\s@]+$/i; + return pattern.test(candidate) && isValidDirectCoreBaseUrl(candidate, allowInsecure) ? candidate : null; +} + +/** The HTTPS origin form, the default the node commands require. */ +export function httpsOrigin(value: string): string | null { + return origin(value, false); } /** @@ -18,9 +26,19 @@ export function httpsOrigin(value: string): string | null { * pass it: the installation's public URL, whose reverse proxy sends * `/node-install/*` to this console. Unlike the browser's address, it is the * same from every machine. Null when other machines can't use it: loopback - * (`local_only`), missing, or not an HTTPS origin. + * (`local_only`), missing, or not an HTTPS origin unless `allowInsecure` is set. */ -export function nodeSourceUrl(installation: Pick