omitEmpty on tlsAllowInsecureConnection causes infinite loop when value is false

[ThomasVerhoeven1998]

We found an issue with tlsAllowInsecureConnection, when set to false it is constantly removed by the operator even though we set it on PulsarConnection resource

I think it is a consequence of the omitEmpty in its definition
false is acting as the nil value for a boolean, therefore it gets omitted. Is this correct?

what's the way forward for us?
can we just drop the tlsAllowInsecureConnection from a spec like the one below?

apiVersion: resource.streamnative.io/v1alpha1
kind: PulsarConnection
metadata:
  name: pulsar-prd-connection
  namespace: prd
spec:
  adminServiceSecureURL: https://...
  adminServiceURL: https://...
  authentication:
    tls:
      clientCertificateKeyPath: /certs/tls.key
      clientCertificatePath: /certs/tls.crt
  brokerServiceSecureURL: pulsar+ssl://...
  tlsAllowInsecureConnection: false
  tlsEnableHostnameVerification: true
  tlsTrustCertsFilePath: /certs/ca.crt

Possible this issue is present on more fields

[DavidLindbom]

Hi, I think we have a related issue.

When setting topicAutoCreationConfig.allow: false on a PulsarNamespace resource the operator updates the object with the field removed which causes our gitops tool to reapply the field. Over and over again.

This likely affects other boolean fields in the API types as well so removing omitempty from all bool values seems like a good overall pattern.

[ThomasVerhoeven1998]

@freeznet what's your thought on this?