Skip to content

Derive the shape-affecting config keys instead of hand-maintaining TEMPLATE_SHAPE_KEYS #405

Description

@zantvoort

SqlTemplateImpl.TEMPLATE_SHAPE_KEYS = Set.of(ANSI_ESCAPING) (storm-core/src/main/java/st/orm/core/template/impl/SqlTemplateImpl.java:71) is the hand-maintained list of config properties that change generated SQL and must therefore participate in the compilation cache key. Adding a new SQL-shaping property and forgetting to add it here produces cache hits serving SQL built under a different configuration: a silent wrong-output bug that no test would naturally catch.

Mark shape-affecting keys at their declaration in StormConfig and derive the set, so omission becomes impossible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    corestorm-core and foundation workenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions