Skip to content

Transaction observations bypass the Micrometer convention, and the Ktor delegating observer drops them entirely #400

Description

@zantvoort
  • MicrometerQueryObserver.onTransaction (storm-micrometer/src/main/java/st/orm/micrometer/MicrometerQueryObserver.java:94-99) hardcodes the observation name and keys with a plain Observation.Context, bypassing the ObservationConvention that onExecute honors, so transaction observations cannot be renamed or re-tagged.
  • DelegatingQueryObserver (storm-ktor/src/main/kotlin/st/orm/ktor/DelegatingQueryObserver.kt:27-33) overrides only onExecute, so every Ktor application silently emits no storm.transaction observations at all.
  • QueryContext.shapeId() (storm-core/src/main/java/st/orm/core/spi/QueryContext.java:78) is exactly the low-cardinality statement identity suited to a metric tag and is never used by the observer.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingktorKtor integration

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions