Use STRING_SPLIT for parameterized IN clauses in SqlServer store (#127)

Author: stidsborg

Stores/SqlServer/Cleipnir.ResilientFunctions.SqlServer/SqlGenerator.cs

@@ -17,36 +17,42 @@ namespace Cleipnir.ResilientFunctions.SqlServer;
 
 public class SqlGenerator(string tablePrefix)
 {
+    private string? _interruptSql;
     public StoreCommand Interrupt(IEnumerable<StoredId> storedIds)
     {
-        var sql = @$"
+        _interruptSql ??= @$"
                 UPDATE {tablePrefix}
-                SET 
+                SET
                     Interrupted = 1,
-                    Status = 
-                        CASE 
+                    Status =
+                        CASE
                             WHEN Status = {(int)Status.Suspended} THEN {(int)Status.Postponed}
                             ELSE Status
                         END,
-                    Expires = 
+                    Expires =
                         CASE
                             WHEN Status = {(int)Status.Postponed} THEN 0
                             WHEN Status = {(int)Status.Suspended} THEN 0
                             ELSE Expires
                         END
-                WHERE Id IN ({storedIds.Select(id => $"'{id.AsGuid}'").StringJoin(", ")});";
+                WHERE Id IN (SELECT CAST(value AS UNIQUEIDENTIFIER) FROM STRING_SPLIT(@Ids, ','));";
 
-        return StoreCommand.Create(sql);
+        var command = StoreCommand.Create(_interruptSql);
+        command.AddParameter("@Ids", storedIds.ToCommaSeparatedIds());
+        return command;
     }
 
+    private string? _resetInterruptedSql;
     public StoreCommand ResetInterrupted(IEnumerable<StoredId> storedIds)
     {
-        var sql = @$"
+        _resetInterruptedSql ??= @$"
                 UPDATE {tablePrefix}
                 SET Interrupted = 0
-                WHERE Id IN ({storedIds.Select(id => $"'{id.AsGuid}'").StringJoin(", ")});";
+                WHERE Id IN (SELECT CAST(value AS UNIQUEIDENTIFIER) FROM STRING_SPLIT(@Ids, ','));";
 
-        return StoreCommand.Create(sql);
+        var command = StoreCommand.Create(_resetInterruptedSql);
+        command.AddParameter("@Ids", storedIds.ToCommaSeparatedIds());
+        return command;
     }
 
     public StoreCommand InsertEffects(StoredId storedId, IReadOnlyList<StoredEffectChange> changes, SnapshotStorageSession session, string paramPrefix)
@@ -118,14 +124,16 @@ public async Task<StoredEffectsWithSession> ReadEffects(SqlDataReader reader, Re
         return new StoredEffectsWithSession(effects, session);
     }
 
+    private string? _getEffectsBulkSql;
     public StoreCommand GetEffects(IEnumerable<StoredId> storedIds)
     {
-        var sql = @$"
+        _getEffectsBulkSql ??= @$"
             SELECT Id, Effects
             FROM {tablePrefix}
-            WHERE Id IN ({storedIds.InClause()})";
+            WHERE Id IN (SELECT CAST(value AS UNIQUEIDENTIFIER) FROM STRING_SPLIT(@Ids, ','))";
 
-        var command = StoreCommand.Create(sql);
+        var command = StoreCommand.Create(_getEffectsBulkSql);
+        command.AddParameter("@Ids", storedIds.ToCommaSeparatedIds());
         return command;
     }
 
@@ -467,11 +475,11 @@ public StoreCommand RestartExecutions(IReadOnlyList<StoredId> storedIds, Replica
                    inserted.Parent,
                    inserted.Owner,
                    inserted.Effects
-            WHERE Id IN ({{0}}) AND Owner IS NULL;";
+            WHERE Id IN (SELECT CAST(value AS UNIQUEIDENTIFIER) FROM STRING_SPLIT(@Ids, ',')) AND Owner IS NULL;";
 
-        var sql = string.Format(_restartExecutionsSql, storedIds.InClause());
-        var storeCommand = StoreCommand.Create(sql);
+        var storeCommand = StoreCommand.Create(_restartExecutionsSql);
         storeCommand.AddParameter("@Owner", replicaId.AsGuid);
+        storeCommand.AddParameter("@Ids", storedIds.ToCommaSeparatedIds());
 
         return storeCommand;
     }
@@ -637,15 +645,17 @@ public StoreCommand GetMessages(StoredId storedId, IReadOnlyList<long> skipPosit
         return messages;
     }
 
+    private string? _getMessagesBulkSql;
     public StoreCommand GetMessages(IEnumerable<StoredId> storedIds)
     {
-        var sql = @$"
+        _getMessagesBulkSql ??= @$"
             SELECT Id, Position, Content
             FROM {tablePrefix}_Messages
-            WHERE Id IN ({storedIds.InClause()})
+            WHERE Id IN (SELECT CAST(value AS UNIQUEIDENTIFIER) FROM STRING_SPLIT(@Ids, ','))
             ORDER BY Position;";
 
-        var command = StoreCommand.Create(sql);
+        var command = StoreCommand.Create(_getMessagesBulkSql);
+        command.AddParameter("@Ids", storedIds.ToCommaSeparatedIds());
         return command;
     }
 

Stores/SqlServer/Cleipnir.ResilientFunctions.SqlServer/SqlServerEffectsStore.cs

@@ -87,9 +87,10 @@ public async Task<Dictionary<StoredId, List<StoredEffect>>> GetEffectResults(IEn
         var sql = @$"
             SELECT Id, Effects
             FROM {_tableName}
-            WHERE Id IN ({storedIdsList.InClause()})";
+            WHERE Id IN (SELECT CAST(value AS UNIQUEIDENTIFIER) FROM STRING_SPLIT(@Ids, ','))";
 
         var command = StoreCommand.Create(sql);
+        command.AddParameter("@Ids", storedIdsList.ToCommaSeparatedIds());
         await using var reader = await _commandExecutor.Execute(command);
 
         foreach (var storedId in storedIdsList)

Stores/SqlServer/Cleipnir.ResilientFunctions.SqlServer/SqlServerMessageStore.cs

@@ -131,6 +131,8 @@ INSERT INTO {_tablePrefix}_Messages
             command.Parameters.AddWithValue($"@Position{i}", position);
             command.Parameters.AddWithValue($"@Content{i}", content);
         }
+        foreach (var (value, name) in interuptsSql.Parameters)
+            command.Parameters.AddWithValue(name, value);
 
         await command.ExecuteNonQueryAsync();
     }
@@ -247,11 +249,12 @@ public async Task<IDictionary<StoredId, long>> GetMaxPositions(IReadOnlyList<Sto
         var sql = @$"
             SELECT Id, MAX(Position)
             FROM {_tablePrefix}_Messages
-            WHERE Id IN ({storedIds.Select(id => $"'{id}'").StringJoin(", ")})
+            WHERE Id IN (SELECT CAST(value AS UNIQUEIDENTIFIER) FROM STRING_SPLIT(@Ids, ','))
             GROUP BY Id;";
 
         await using var conn = await CreateConnection();
         await using var command = new SqlCommand(sql, conn);
+        command.Parameters.AddWithValue("@Ids", storedIds.ToCommaSeparatedIds());
 
         var positions = new Dictionary<StoredId, long>(capacity: storedIds.Count);
         foreach (var storedId in storedIds)

Stores/SqlServer/Cleipnir.ResilientFunctions.SqlServer/StoreCommandExtensions.cs

@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using System.Linq;
 using Cleipnir.ResilientFunctions.Storage;
 using Microsoft.Data.SqlClient;
 
@@ -30,6 +31,12 @@ public static SqlBatchCommand ToSqlBatchCommand(this StoreCommand command)
     public static SqlBatch ToSqlBatch(this StoreCommands commands) => commands.Commands.CreateBatch();
 }
 
+internal static class StoredIdExtensions
+{
+    public static string ToCommaSeparatedIds(this IEnumerable<StoredId> storedIds)
+        => string.Join(",", storedIds.Select(id => id.AsGuid));
+}
+
 internal static class StoreCommandsHelper
 {
     public static SqlBatch CreateBatch(params StoreCommand[] commands) => CreateBatch((IEnumerable<StoreCommand>) commands);