Rename UpsertWithoutFlush to FlushlessUpsert and use it in QueueClient

Author: stidsborg

Core/Cleipnir.ResilientFunctions.Tests/InMemoryTests/RFunctionTests/EffectTests.cs

@@ -151,6 +151,6 @@ public override Task UtcNowEffectSunshineTest()
         => UtcNowEffectSunshineTest(FunctionStoreFactory.Create());
 
     [TestMethod]
-    public override Task UpsertWithoutFlushIsNotStoredUntilFlushed()
-        => UpsertWithoutFlushIsNotStoredUntilFlushed(FunctionStoreFactory.Create());
+    public override Task FlushlessUpsertIsNotStoredUntilFlushed()
+        => FlushlessUpsertIsNotStoredUntilFlushed(FunctionStoreFactory.Create());
 }

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/FunctionTests/EffectTests.cs

@@ -1495,8 +1495,8 @@ async Task (workflow) =>
         syncedList[0].ShouldBe(syncedList[1]);
     }
 
-    public abstract Task UpsertWithoutFlushIsNotStoredUntilFlushed();
-    public async Task UpsertWithoutFlushIsNotStoredUntilFlushed(Task<IFunctionStore> storeTask)
+    public abstract Task FlushlessUpsertIsNotStoredUntilFlushed();
+    public async Task FlushlessUpsertIsNotStoredUntilFlushed(Task<IFunctionStore> storeTask)
     {
         var store = await storeTask;
         var storedId = TestStoredId.Create();
@@ -1522,7 +1522,7 @@ public async Task UpsertWithoutFlushIsNotStoredUntilFlushed(Task<IFunctionStore>
         );
 
         var effectId = new EffectId([1]);
-        effectResults.UpsertWithoutFlush(effectId, alias: null, 42);
+        effectResults.FlushlessUpsert(effectId, alias: null, 42);
 
         // before flush nothing should be stored
         var fetchedResults = await effectStore.GetEffectResults(storedId);

Core/Cleipnir.ResilientFunctions/Domain/Effect.cs

@@ -65,7 +65,7 @@ internal async Task Upsert<T>(string alias, T value, bool flush = true)
             flush
         );
     internal Task Upsert<T>(EffectId effectId, T value, string? alias, bool flush) => effectResults.Upsert(effectId, alias, value, flush);
-    internal void UpsertWithoutFlush<T>(EffectId effectId, T value, string? alias) => effectResults.UpsertWithoutFlush(effectId, alias, value);
+    internal void FlushlessUpsert<T>(EffectId effectId, T value, string? alias) => effectResults.FlushlessUpsert(effectId, alias, value);
 
     internal Task Upserts(IEnumerable<EffectResult> values, bool flush)
         => effectResults.Upserts(values, flush);

Core/Cleipnir.ResilientFunctions/Domain/EffectResults.cs

@@ -152,7 +152,7 @@ await FlushOrAddToPending(
         );
     }
 
-    internal void UpsertWithoutFlush<T>(EffectId effectId, string? alias, T value)
+    internal void FlushlessUpsert<T>(EffectId effectId, string? alias, T value)
     {
         var serializedValue = _serializer.Serialize(value!, typeof(T));
         var storedEffect = StoredEffect.CreateCompleted(effectId, serializedValue, alias);

Core/Cleipnir.ResilientFunctions/Queuing/QueueClient.cs

@@ -67,7 +67,7 @@ public Task<Envelope> PullEnvelope<T>(Workflow workflow, EffectId parentId, Func
             );
 
             if (result == null)
-                await effect.Upsert<object?>(messageId, null, alias: null, flush: false);
+                effect.FlushlessUpsert<object?>(messageId, null, alias: null);
 
             return result;
         }