Remove unused IFunctionStore.SetResult and its tests

`SetResult` was never called from production code; the only callers
were the three `StoreTests` cases that exist to test the method itself.
Drop the interface method, all four store implementations
(InMemory + Postgres + SqlServer + MariaDB), the test wrappers in
`CrashableFunctionStore`, and the abstract test methods plus their
overrides in each store's test project.

Author: stidsborg

Core/Cleipnir.ResilientFunctions.Tests/InMemoryTests/StoreTests.cs

@@ -269,16 +269,4 @@ public override Task GetResultsReturnsEmptyDictionaryForEmptyInput()
     [TestMethod]
     public override Task GetResultsReturnsOnlyExistingFunctionResults()
         => GetResultsReturnsOnlyExistingFunctionResults(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultSucceedsWhenOwnerMatches()
-        => SetResultSucceedsWhenOwnerMatches(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultDoesNothingWhenOwnerDoesNotMatch()
-        => SetResultDoesNothingWhenOwnerDoesNotMatch(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultDoesNothingWhenFunctionDoesNotExist()
-        => SetResultDoesNothingWhenFunctionDoesNotExist(FunctionStoreFactory.Create());
 }

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/StoreTests.cs

@@ -2357,72 +2357,4 @@ await store.SucceedFunction(
         results.ContainsKey(nonExistentFunctionId).ShouldBeFalse();
     }
 
-    public abstract Task SetResultSucceedsWhenOwnerMatches();
-    protected async Task SetResultSucceedsWhenOwnerMatches(Task<IFunctionStore> storeTask)
-    {
-        var store = await storeTask;
-        var functionId = TestStoredId.Create();
-        var owner = ReplicaId.NewId();
-        var result = "test result".ToJson().ToUtf8Bytes();
-
-        // Create function with owner
-        await store.CreateFunction(
-            functionId,
-            "humanInstanceId",
-            param: Test.SimpleStoredParameter,
-            leaseExpiration: DateTime.UtcNow.Ticks,
-            postponeUntil: null,
-            timestamp: DateTime.UtcNow.Ticks,
-            parent: null,
-            owner: owner
-        ).ShouldNotBeNullAsync();
-
-        // Set result
-        await store.SetResult(functionId, result, owner);
-
-        // Verify result was set
-        var results = await store.GetResults([functionId]);
-        results[functionId].ShouldBe(result);
-    }
-
-    public abstract Task SetResultDoesNothingWhenOwnerDoesNotMatch();
-    protected async Task SetResultDoesNothingWhenOwnerDoesNotMatch(Task<IFunctionStore> storeTask)
-    {
-        var store = await storeTask;
-        var functionId = TestStoredId.Create();
-        var owner = ReplicaId.NewId();
-        var wrongOwner = ReplicaId.NewId();
-        var result = "test result".ToJson().ToUtf8Bytes();
-
-        // Create function with owner
-        await store.CreateFunction(
-            functionId,
-            "humanInstanceId",
-            param: Test.SimpleStoredParameter,
-            leaseExpiration: DateTime.UtcNow.Ticks,
-            postponeUntil: null,
-            timestamp: DateTime.UtcNow.Ticks,
-            parent: null,
-            owner: owner
-        ).ShouldNotBeNullAsync();
-
-        // Try to set result with wrong owner
-        await store.SetResult(functionId, result, wrongOwner);
-
-        // Verify result was not set
-        var results = await store.GetResults([functionId]);
-        results[functionId].ShouldBeNull();
-    }
-
-    public abstract Task SetResultDoesNothingWhenFunctionDoesNotExist();
-    protected async Task SetResultDoesNothingWhenFunctionDoesNotExist(Task<IFunctionStore> storeTask)
-    {
-        var store = await storeTask;
-        var nonExistentFunctionId = TestStoredId.Create();
-        var owner = ReplicaId.NewId();
-        var result = "test result".ToJson().ToUtf8Bytes();
-
-        // Try to set result for non-existent function (should not throw)
-        await store.SetResult(nonExistentFunctionId, result, owner);
-    }
 }

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/WatchDogsTests/CrashableFunctionStore.cs

@@ -215,11 +215,6 @@ public Task<bool> DeleteFunction(StoredId storedId)
             ? Task.FromException<IReadOnlyDictionary<StoredId, byte[]?>>(new TimeoutException())
             : _inner.GetResults(storedIds);
 
-    public Task SetResult(StoredId storedId, byte[] result, ReplicaId expectedReplica)
-        => _crashed
-            ? Task.FromException(new TimeoutException())
-            : _inner.SetResult(storedId, result, expectedReplica);
-
     public IFunctionStore WithPrefix(string prefix) => _inner.WithPrefix(prefix);
 }
 

Core/Cleipnir.ResilientFunctions/Storage/IFunctionStore.cs

@@ -110,5 +110,4 @@ Task<bool> SuspendFunction(
 
     IFunctionStore WithPrefix(string prefix);
     Task<IReadOnlyDictionary<StoredId, byte[]?>> GetResults(IEnumerable<StoredId> storedIds);
-    Task SetResult(StoredId storedId, byte[] result, ReplicaId expectedReplica);
 }

Core/Cleipnir.ResilientFunctions/Storage/InMemoryFunctionStore.cs

@@ -563,22 +563,6 @@ public virtual Task<bool> DeleteFunction(StoredId storedId)
         }
     }
 
-    public Task SetResult(StoredId storedId, byte[] result, ReplicaId expectedReplica)
-    {
-        lock (_sync)
-        {
-            if (!_states.ContainsKey(storedId))
-                return Task.CompletedTask;
-
-            var state = _states[storedId];
-            if (state.Owner != expectedReplica)
-                return Task.CompletedTask;
-
-            state.Result = result;
-            return Task.CompletedTask;
-        }
-    }
-
     private class InnerState
     {
         public StoredId StoredId { get; init; } = null!;

Samples/Sample.ConsoleApp/Utils/CrashableFunctionStore.cs

@@ -196,11 +196,6 @@ public Task<bool> DeleteFunction(StoredId storedId)
             ? Task.FromException<IReadOnlyDictionary<StoredId, byte[]?>>(new TimeoutException())
             : _inner.GetResults(storedIds);
 
-    public Task SetResult(StoredId storedId, byte[] result, ReplicaId expectedReplica)
-        => _crashed
-            ? Task.FromException(new TimeoutException())
-            : _inner.SetResult(storedId, result, expectedReplica);
-
     public IFunctionStore WithPrefix(string prefix)
         => _inner.WithPrefix(prefix);
 }

Stores/MariaDB/Cleipnir.ResilientFunctions.MariaDB.Tests/StoreTests.cs

@@ -258,16 +258,4 @@ public override Task GetResultsReturnsEmptyDictionaryForEmptyInput()
     [TestMethod]
     public override Task GetResultsReturnsOnlyExistingFunctionResults()
         => GetResultsReturnsOnlyExistingFunctionResults(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultSucceedsWhenOwnerMatches()
-        => SetResultSucceedsWhenOwnerMatches(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultDoesNothingWhenOwnerDoesNotMatch()
-        => SetResultDoesNothingWhenOwnerDoesNotMatch(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultDoesNothingWhenFunctionDoesNotExist()
-        => SetResultDoesNothingWhenFunctionDoesNotExist(FunctionStoreFactory.Create());
 }

Stores/MariaDB/Cleipnir.ResilientFunctions.MariaDB/MariaDbFunctionStore.cs

@@ -913,28 +913,6 @@ public IFunctionStore WithPrefix(string prefix)
         return results;
     }
 
-    private string? _setResultSql;
-    public async Task SetResult(StoredId storedId, byte[] result, ReplicaId expectedReplica)
-    {
-        await using var conn = await CreateOpenConnection(_connectionString);
-        _setResultSql ??= $@"
-            UPDATE {_tablePrefix}
-            SET result_json = ?
-            WHERE id = ? AND owner = ?";
-
-        await using var command = new MySqlCommand(_setResultSql, conn)
-        {
-            Parameters =
-            {
-                new() { Value = result },
-                new() { Value = storedId.AsGuid.ToString("N") },
-                new() { Value = expectedReplica.AsGuid.ToString("N") }
-            }
-        };
-
-        await command.ExecuteNonQueryAsync();
-    }
-
     private string? _deleteFunctionSql;
     private async Task<bool> DeleteStoredFunction(StoredId storedId)
     {

Stores/PostgreSQL/Cleipnir.ResilientFunctions.PostgreSQL.Tests/StoreTests.cs

@@ -261,16 +261,4 @@ public override Task GetResultsReturnsEmptyDictionaryForEmptyInput()
     [TestMethod]
     public override Task GetResultsReturnsOnlyExistingFunctionResults()
         => GetResultsReturnsOnlyExistingFunctionResults(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultSucceedsWhenOwnerMatches()
-        => SetResultSucceedsWhenOwnerMatches(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultDoesNothingWhenOwnerDoesNotMatch()
-        => SetResultDoesNothingWhenOwnerDoesNotMatch(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultDoesNothingWhenFunctionDoesNotExist()
-        => SetResultDoesNothingWhenFunctionDoesNotExist(FunctionStoreFactory.Create());
 }

Stores/PostgreSQL/Cleipnir.ResilientFunctions.PostgreSQL/PostgreSqlFunctionStore.cs

@@ -831,28 +831,6 @@ public IFunctionStore WithPrefix(string prefix)
         return results;
     }
 
-    private string? _setResultSql;
-    public async Task SetResult(StoredId storedId, byte[] result, ReplicaId expectedReplica)
-    {
-        await using var conn = await CreateConnection();
-        _setResultSql ??= $@"
-            UPDATE {_tableName}
-            SET result_json = $1
-            WHERE id = $2 AND owner = $3";
-
-        await using var command = new NpgsqlCommand(_setResultSql, conn)
-        {
-            Parameters =
-            {
-                new() { Value = result },
-                new() { Value = storedId.AsGuid },
-                new() { Value = expectedReplica.AsGuid }
-            }
-        };
-
-        await command.ExecuteNonQueryAsync();
-    }
-
     private string? _deleteFunctionSql;
     private async Task<bool> DeleteStoredFunction(StoredId storedId)
     {