Remove Utilities record and Register subsystem (#135)

Author: stidsborg

Core/Cleipnir.ResilientFunctions.Tests/InMemoryTests/UtilsTests/RegisterTests.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
-using Cleipnir.ResilientFunctions.CoreRuntime.Invocation;
 using Cleipnir.ResilientFunctions.Domain;
 using Cleipnir.ResilientFunctions.Messaging;
 using Cleipnir.ResilientFunctions.Storage;
@@ -22,7 +21,6 @@ public class CrashableFunctionStore : IFunctionStore
     private readonly CrashableEffectStore _crashableEffectStore;
     public IEffectsStore EffectsStore => _crashableEffectStore;
     public ICorrelationStore CorrelationStore => _crashed ? throw new TimeoutException() : _inner.CorrelationStore;
-    public Utilities Utilities => _crashed ? throw new TimeoutException() : _inner.Utilities;
     public IReplicaStore ReplicaStore => _crashed ? throw new TimeoutException() : _inner.ReplicaStore;
 
     public CrashableFunctionStore(IFunctionStore inner)

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/UtilsTests/RegisterTests.cs

@@ -20,15 +20,13 @@ public class Invoker<TParam, TReturn>
 
     private readonly InvocationHelper<TParam, TReturn> _invocationHelper;
     private readonly UnhandledExceptionHandler _unhandledExceptionHandler;
-    private readonly Utilities _utilities;
     private readonly FlowsManager _flowsManager;
 
     internal Invoker(
         FlowType flowType, StoredType storedType,
         Func<TParam, Workflow, Task<Result<TReturn>>> inner,
         InvocationHelper<TParam, TReturn> invocationHelper,
         UnhandledExceptionHandler unhandledExceptionHandler,
-        Utilities utilities,
         ReplicaId replicaId,
         FlowsManager flowsManager
     )
@@ -39,7 +37,6 @@ FlowsManager flowsManager
         _inner = inner;
         _invocationHelper = invocationHelper;
         _unhandledExceptionHandler = unhandledExceptionHandler;
-        _utilities = utilities;
         _flowsManager = flowsManager;
     }
 
@@ -289,7 +286,7 @@ await _invocationHelper.PersistFunctionInStore(
             var queueManager = _invocationHelper.CreateQueueManager(flowId, storedId, effect, flowState, flowTimeouts, _unhandledExceptionHandler);
             disposables.Add(queueManager);
             var messageWriter = _invocationHelper.CreateMessageWriter(storedId);
-            var workflow = new Workflow(flowId, storedId, effect, _utilities, correlations, queueManager, _invocationHelper.UtcNow, messageWriter);
+            var workflow = new Workflow(flowId, storedId, effect, correlations, queueManager, _invocationHelper.UtcNow, messageWriter);
 
             return new PreparedInvocation(
                 persisted,
@@ -346,7 +343,6 @@ private async Task<PreparedReInvocation> PrepareForReInvocation(StoredId storedI
                 flowId,
                 storedId,
                 effect,
-                _utilities,
                 correlations,
                 queueManager,
                 _invocationHelper.UtcNow,

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/WatchDogsTests/CrashableFunctionStore.cs

@@ -13,19 +13,17 @@ public class Workflow
     public FlowId FlowId { get; }
     internal StoredId StoredId { get; }
     public Effect Effect { get; }
-    public Utilities Utilities { get; }
     public Correlations Correlations { get; }
 
     private QueueManager _queueManager;
     private readonly UtcNow _utcNow;
     private MessageWriter MessageWriter { get; }
 
 
-    public Workflow(FlowId flowId, StoredId storedId, Effect effect, Utilities utilities, Correlations correlations, QueueManager queueManager, UtcNow utcNow, MessageWriter messageWriter)
+    public Workflow(FlowId flowId, StoredId storedId, Effect effect, Correlations correlations, QueueManager queueManager, UtcNow utcNow, MessageWriter messageWriter)
     {
         FlowId = flowId;
         StoredId = storedId;
-        Utilities = utilities;
         Effect = effect;
         Correlations = correlations;
         _queueManager = queueManager;

Core/Cleipnir.ResilientFunctions/CoreRuntime/Invocation/Invoker.cs

@@ -228,7 +228,6 @@ public FuncRegistration<TParam, TReturn> RegisterFunc<TParam, TReturn>(
                 inner,
                 invocationHelper,
                 settingsWithDefaults.UnhandledExceptionHandler,
-                _functionStore.Utilities,
                 ClusterInfo.ReplicaId,
                 _flowsManager
             );
@@ -318,7 +317,6 @@ private ParamlessRegistration RegisterParamless(
                 inner,
                 invocationHelper,
                 settingsWithDefaults.UnhandledExceptionHandler,
-                _functionStore.Utilities,
                 ClusterInfo.ReplicaId,
                 _flowsManager
             );
@@ -408,7 +406,6 @@ public ActionRegistration<TParam> RegisterAction<TParam>(
                 inner,
                 invocationHelper,
                 settingsWithDefaults.UnhandledExceptionHandler,
-                _functionStore.Utilities,
                 ClusterInfo.ReplicaId,
                 _flowsManager
             );

Core/Cleipnir.ResilientFunctions/CoreRuntime/Invocation/Utilities.cs

@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.Threading.Tasks;
-using Cleipnir.ResilientFunctions.CoreRuntime.Invocation;
 using Cleipnir.ResilientFunctions.Domain;
 using Cleipnir.ResilientFunctions.Messaging;
 using Cleipnir.ResilientFunctions.Storage.Session;
@@ -13,7 +12,6 @@ public interface IFunctionStore
     public IMessageStore MessageStore { get; }
     public IEffectsStore EffectsStore { get; }
     public ICorrelationStore CorrelationStore { get; }
-    public Utilities Utilities { get; }
     public IReplicaStore ReplicaStore { get; }
     public Task Initialize();
 

Core/Cleipnir.ResilientFunctions/CoreRuntime/Invocation/Workflow.cs

@@ -3,13 +3,10 @@
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
-using Cleipnir.ResilientFunctions.CoreRuntime.Invocation;
 using Cleipnir.ResilientFunctions.Domain;
 using Cleipnir.ResilientFunctions.Helpers;
 using Cleipnir.ResilientFunctions.Messaging;
 using Cleipnir.ResilientFunctions.Storage.Session;
-using Cleipnir.ResilientFunctions.Utils;
-using Cleipnir.ResilientFunctions.Utils.Register;
 
 namespace Cleipnir.ResilientFunctions.Storage;
 
@@ -25,17 +22,10 @@ public class InMemoryFunctionStore : IFunctionStore, IMessageStore
     public IEffectsStore EffectsStore => _effectsStore;
     private readonly InMemoryCorrelationStore _correlationStore = new();
     public ICorrelationStore CorrelationStore => _correlationStore;
-    public Utilities Utilities { get; }
     public IReplicaStore ReplicaStore { get; } = new InMemoryReplicaStore();
 
     public Task Initialize() => Task.CompletedTask;
 
-    public InMemoryFunctionStore()
-    {
-        var underlyingRegister = new UnderlyingInMemoryRegister();
-        Utilities = new Utilities(new Register(underlyingRegister));
-    }
-    
     #region FunctionStore
 
     public virtual Task<IStorageSession?> CreateFunction(