Remove dead FlowsManager.Suspend and Workflow flowsManager wiring

Author: stidsborg

Core/Cleipnir.ResilientFunctions/CoreRuntime/FlowsManager.cs

@@ -1,9 +1,7 @@
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 using System.Threading.Tasks;
-using Cleipnir.ResilientFunctions.Domain.Exceptions.Commands;
 using Cleipnir.ResilientFunctions.Storage;
 
 namespace Cleipnir.ResilientFunctions.CoreRuntime;
@@ -79,8 +77,4 @@ public void CompleteThread(StoredId id)
             if (_dict.TryGetValue(id, out var flowState))
                 flowState.SubflowCompleted();
     }
-
-    [DoesNotReturn]
-    public async Task Suspend(StoredId id) => throw new SuspendInvocationException();
-
 }

Core/Cleipnir.ResilientFunctions/CoreRuntime/Invocation/Invoker.cs

@@ -289,7 +289,7 @@ await _invocationHelper.PersistFunctionInStore(
             var queueManager = _invocationHelper.CreateQueueManager(flowId, storedId, effect, flowState, flowTimeouts, _unhandledExceptionHandler);
             disposables.Add(queueManager);
             var messageWriter = _invocationHelper.CreateMessageWriter(storedId);
-            var workflow = new Workflow(flowId, storedId, effect, _utilities, correlations, queueManager, _invocationHelper.UtcNow, messageWriter, _flowsManager);
+            var workflow = new Workflow(flowId, storedId, effect, _utilities, correlations, queueManager, _invocationHelper.UtcNow, messageWriter);
 
             return new PreparedInvocation(
                 persisted,
@@ -350,8 +350,7 @@ private async Task<PreparedReInvocation> PrepareForReInvocation(StoredId storedI
                 correlations,
                 queueManager,
                 _invocationHelper.UtcNow,
-                messageWriter,
-                _flowsManager
+                messageWriter
             );
 
             return new PreparedReInvocation(

Core/Cleipnir.ResilientFunctions/CoreRuntime/Invocation/Workflow.cs

@@ -17,12 +17,11 @@ public class Workflow
     public Correlations Correlations { get; }
 
     private QueueManager _queueManager;
-    private FlowsManager _flowsManager;
     private readonly UtcNow _utcNow;
     private MessageWriter MessageWriter { get; }
 
 
-    public Workflow(FlowId flowId, StoredId storedId, Effect effect, Utilities utilities, Correlations correlations, QueueManager queueManager, UtcNow utcNow, MessageWriter messageWriter, FlowsManager flowsManager)
+    public Workflow(FlowId flowId, StoredId storedId, Effect effect, Utilities utilities, Correlations correlations, QueueManager queueManager, UtcNow utcNow, MessageWriter messageWriter)
     {
         FlowId = flowId;
         StoredId = storedId;
@@ -32,7 +31,6 @@ public Workflow(FlowId flowId, StoredId storedId, Effect effect, Utilities utili
         _queueManager = queueManager;
         _utcNow = utcNow;
         MessageWriter = messageWriter;
-        _flowsManager = flowsManager;
     }
 
     public async Task RegisterCorrelation(string correlation) => await Correlations.Register(correlation);