Remove Postman wrapper, call MessageWriters directly (#139)

Postman was a two-method passthrough over MessageWriters with no
behaviour of its own. Inline the calls in the registration classes
and drop the type.

Author: stidsborg

Core/Cleipnir.ResilientFunctions/ActionRegistration.cs

@@ -26,9 +26,8 @@ public ActionRegistration(
         Invoker<TParam, Unit> invoker,
         ControlPanelFactory<TParam> controlPanelFactory,
         MessageWriters messageWriters,
-        Postman postman,
         UtcNow utcNow
-    ) : base(storedType, postman, functionStore, utcNow)
+    ) : base(storedType, functionStore, utcNow)
     {
         Type = flowType;
         _invoker = invoker;
@@ -59,8 +58,8 @@ public async Task SendMessage<T>(
         FlowInstance flowInstance,
         T message,
         string? idempotencyKey = null
-    ) where T : class => await Postman.SendMessage(StoredId.Create(StoredType, flowInstance.Value), message, idempotencyKey);
+    ) where T : class => await MessageWriters.For(flowInstance).AppendMessage(message, idempotencyKey);
 
     public async Task SendMessages(IReadOnlyList<BatchedMessage> messages)
-        => await Postman.SendMessages(messages);
+        => await MessageWriters.AppendMessages(messages);
 }

Core/Cleipnir.ResilientFunctions/BaseRegistration.cs

@@ -3,25 +3,22 @@
 using System.Threading.Tasks;
 using Cleipnir.ResilientFunctions.CoreRuntime;
 using Cleipnir.ResilientFunctions.Domain;
-using Cleipnir.ResilientFunctions.Messaging;
 using Cleipnir.ResilientFunctions.Storage;
 
 namespace Cleipnir.ResilientFunctions;
 
 public abstract class BaseRegistration
 {
     private readonly IFunctionStore _functionStore;
-    protected Postman Postman { get; } 
     public StoredType StoredType { get; }
     protected UtcNow UtcNow { get; }
 
-    protected BaseRegistration(StoredType storedType, Postman postman, IFunctionStore functionStore, UtcNow utcNow)
+    protected BaseRegistration(StoredType storedType, IFunctionStore functionStore, UtcNow utcNow)
     {
         _functionStore = functionStore;
         StoredType = storedType;
-        Postman = postman;
         UtcNow = utcNow;
-    } 
+    }
 
     public StoredId MapToStoredId(FlowInstance instance) => StoredId.Create(StoredType, instance.Value);
 

Core/Cleipnir.ResilientFunctions/FuncRegistration.cs

@@ -25,9 +25,8 @@ public FuncRegistration(
         Invoker<TParam, TReturn> invoker,
         ControlPanelFactory<TParam, TReturn> controlPanelFactory,
         MessageWriters messageWriters,
-        Postman postman,
         UtcNow utcNow
-    ) : base(storedType, postman, functionStore, utcNow)
+    ) : base(storedType, functionStore, utcNow)
     {
         Type = flowType;
         _invoker = invoker;
@@ -59,8 +58,8 @@ public async Task SendMessage<T>(
         FlowInstance flowInstance,
         T message,
         string? idempotencyKey = null
-    ) where T : class => await Postman.SendMessage(StoredId.Create(StoredType, flowInstance.Value), message, idempotencyKey);
+    ) where T : class => await MessageWriters.For(flowInstance).AppendMessage(message, idempotencyKey);
 
     public async Task SendMessages(IReadOnlyList<BatchedMessage> messages)
-        => await Postman.SendMessages(messages);
+        => await MessageWriters.AppendMessages(messages);
 }

Core/Cleipnir.ResilientFunctions/FunctionsRegistry.cs

@@ -258,16 +258,13 @@ public FuncRegistration<TParam, TReturn> RegisterFunc<TParam, TReturn>(
                 serializer
             );
 
-            var postman = new Postman(messageWriters);
-            
             var registration = new FuncRegistration<TParam, TReturn>(
                 flowType,
                 storedType,
                 _functionStore,
                 invoker,
                 controlPanels,
                 messageWriters,
-                postman,
                 _settings.UtcNow
             );
             _functions[flowType] = registration;
@@ -343,16 +340,13 @@ private ParamlessRegistration RegisterParamless(
                 serializer
             );
 
-            var postman = new Postman(messageWriters);
-
             var registration = new ParamlessRegistration(
                 flowType,
                 storedType,
                 _functionStore,
                 invoker,
                 controlPanels,
                 messageWriters,
-                postman,
                 _settings.UtcNow
             );
             _functions[flowType] = registration;
@@ -427,16 +421,13 @@ public ActionRegistration<TParam> RegisterAction<TParam>(
                 _functionStore,
                 serializer
             );
-            var postman = new Postman(messageWriters);
-            
             var registration = new ActionRegistration<TParam>(
                 flowType,
                 storedType,
                 _functionStore,
                 rActionInvoker,
                 controlPanels,
                 messageWriters,
-                postman,
                 _settings.UtcNow
             );
             _functions[flowType] = registration;

Core/Cleipnir.ResilientFunctions/Messaging/Postman.cs

@@ -27,9 +27,8 @@ public ParamlessRegistration(
         Invoker<Unit, Unit> invoker,
         ControlPanelFactory controlPanelFactory,
         MessageWriters messageWriters,
-        Postman postman,
         UtcNow utcNow
-    ) : base(storedType, postman, functionStore, utcNow)
+    ) : base(storedType, functionStore, utcNow)
     {
         Type = flowType;
         _invoker = invoker;
@@ -70,9 +69,9 @@ public async Task SendMessage<T>(
                 await Schedule(flowInstance);
         }
 
-        await Postman.SendMessage(StoredId.Create(StoredType, flowInstance.Value), message, idempotencyKey);
+        await MessageWriters.For(flowInstance).AppendMessage(message, idempotencyKey);
     }
 
     public async Task SendMessages(IReadOnlyList<BatchedMessage> messages)
-        => await Postman.SendMessages(messages);
+        => await MessageWriters.AppendMessages(messages);
 }