From 1035beeadd448fee9432103022543e7afd03603a Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 7 Oct 2026 21:14:33 +0000 Subject: [PATCH 1/2] test: migrate `stats/base/dists/lognormal/logcdf` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Sonnet 5.5 Claude-Session: https://claude.ai/code/session_01EUvHdR6pRVKoSA44WKwv9Y --- .../dists/lognormal/logcdf/test/test.factory.js | 14 +++----------- .../dists/lognormal/logcdf/test/test.logcdf.js | 14 +++----------- .../dists/lognormal/logcdf/test/test.native.js | 7 ++----- 3 files changed, 8 insertions(+), 27 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.factory.js index a45ffcf98603..5a8165396c84 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -155,9 +154,8 @@ tape( 'if `sigma` equals `0`, the created function evaluates a degenerate distri tape( 'the created function evaluates the logcdf for `x` given parameters `mu` and `sigma`', function test( t ) { var expected; var logcdf; - var delta; var sigma; - var tol; + var ULP = 49; var mu; var x; var y; @@ -170,13 +168,7 @@ tape( 'the created function evaluates the logcdf for `x` given parameters `mu` a for ( i = 0; i < x.length; i++ ) { logcdf = factory( mu[i], sigma[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1500.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.logcdf.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.logcdf.js index 2485d17a087e..1c3165b9917d 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.logcdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.logcdf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var logcdf = require( './../lib' ); @@ -128,9 +127,8 @@ tape( 'if provided `sigma` equals `0`, the function evaluates a degenerate distr tape( 'the function evaluates the logcdf for `x` given parameters `mu` and `sigma`', function test( t ) { var expected; - var delta; var sigma; - var tol; + var ULP = 49; var mu; var x; var y; @@ -142,13 +140,7 @@ tape( 'the function evaluates the logcdf for `x` given parameters `mu` and `sigm sigma = data.sigma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], mu[i], sigma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1500.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.native.js index 860daf215248..ba9af1d3ff0f 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.native.js @@ -137,6 +137,7 @@ tape( 'if provided `sigma` equals `0`, the function evaluates a degenerate distr tape( 'the function evaluates the logcdf for `x` given parameters `mu` and `sigma`', opts, function test( t ) { var expected; var sigma; + var ULP = 49; var mu; var i; var x; @@ -148,11 +149,7 @@ tape( 'the function evaluates the logcdf for `x` given parameters `mu` and `sigm sigma = data.sigma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], mu[i], sigma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - t.ok( isAlmostSameValue( y, expected[i], 1500 ), 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); } t.end(); }); From 9c17c019bd1e7d3e07a8892ab103d12753e20412 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 11 Oct 2026 14:58:34 +0200 Subject: [PATCH 2/2] Apply batched suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../stats/base/dists/lognormal/logcdf/test/test.factory.js | 3 +-- .../stats/base/dists/lognormal/logcdf/test/test.logcdf.js | 3 +-- .../stats/base/dists/lognormal/logcdf/test/test.native.js | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.factory.js index 5a8165396c84..fa386f1eae37 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.factory.js @@ -155,7 +155,6 @@ tape( 'the created function evaluates the logcdf for `x` given parameters `mu` a var expected; var logcdf; var sigma; - var ULP = 49; var mu; var x; var y; @@ -168,7 +167,7 @@ tape( 'the created function evaluates the logcdf for `x` given parameters `mu` a for ( i = 0; i < x.length; i++ ) { logcdf = factory( mu[i], sigma[i] ); y = logcdf( x[i] ); - t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 49 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.logcdf.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.logcdf.js index 1c3165b9917d..cd2524167d48 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.logcdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.logcdf.js @@ -128,7 +128,6 @@ tape( 'if provided `sigma` equals `0`, the function evaluates a degenerate distr tape( 'the function evaluates the logcdf for `x` given parameters `mu` and `sigma`', function test( t ) { var expected; var sigma; - var ULP = 49; var mu; var x; var y; @@ -140,7 +139,7 @@ tape( 'the function evaluates the logcdf for `x` given parameters `mu` and `sigm sigma = data.sigma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], mu[i], sigma[i] ); - t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 49 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.native.js index ba9af1d3ff0f..d3fbaf59dafe 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/test/test.native.js @@ -137,7 +137,6 @@ tape( 'if provided `sigma` equals `0`, the function evaluates a degenerate distr tape( 'the function evaluates the logcdf for `x` given parameters `mu` and `sigma`', opts, function test( t ) { var expected; var sigma; - var ULP = 49; var mu; var i; var x; @@ -149,7 +148,7 @@ tape( 'the function evaluates the logcdf for `x` given parameters `mu` and `sigm sigma = data.sigma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], mu[i], sigma[i] ); - t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 49 ), true, 'returns expected value' ); } t.end(); });