From 52929b635faff6ec67a12d833ba09bc3c61e5e50 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 7 Oct 2026 14:24:49 +0000 Subject: [PATCH] test: migrate `stats/incr/nanmmeanstdev` to ULP-based assertions Migrate the tests for `stats/incr/nanmmeanstdev` from relative tolerance testing to ULP difference testing by replacing the computed `delta`/`tol` comparison with `@stdlib/assert/is-almost-same-value`. The ULP bound is `0`, which is the measured minimum: the accumulated moving corrected sample standard deviation is bit-for-bit equal to the expected value. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_013YxL644SUL6UDUhBovNN5d --- .../@stdlib/stats/incr/nanmmeanstdev/test/test.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/incr/nanmmeanstdev/test/test.js b/lib/node_modules/@stdlib/stats/incr/nanmmeanstdev/test/test.js index ee1dbc1bf3f4..b95bffcfe4f5 100644 --- a/lib/node_modules/@stdlib/stats/incr/nanmmeanstdev/test/test.js +++ b/lib/node_modules/@stdlib/stats/incr/nanmmeanstdev/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var randu = require( '@stdlib/random/base/randu' ); -var abs = require( '@stdlib/math/base/special/abs' ); var sqrt = require( '@stdlib/math/base/special/sqrt' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var incrnanmmeanstdev = require( './../lib' ); @@ -229,9 +228,7 @@ tape( 'the accumulator function computes a moving arithmetic mean and corrected tape( 'if not provided an input value, the accumulator function returns the current arithmetic mean and corrected sample standard deviation', function test( t ) { var expected; var actual; - var delta; var data; - var tol; var acc; var i; @@ -248,10 +245,7 @@ tape( 'if not provided an input value, the accumulator function returns the curr actual = acc(); t.strictEqual( actual[ 0 ], expected[ 0 ], 'returns expected value' ); - - delta = abs( actual[ 1 ] - expected[ 1 ] ); - tol = EPS * expected[ 1 ]; - t.strictEqual( delta < tol, true, 'expected: '+expected[ 1 ]+'. actual: '+actual+'. tol: '+tol+'. delta: '+delta+'.' ); + t.strictEqual( isAlmostSameValue( actual[ 1 ], expected[ 1 ], 0 ), true, 'returns expected value' ); t.end(); });