From 7a4c843eb4e1907ca6318c5fc9fc0cedcd9dd15d Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 2 Oct 2026 18:27:10 +0000 Subject: [PATCH] test: migrate `simulate/iter/periodic-sinc` to ULP-based assertions Replace the relative tolerance assertions in the `simulate/iter/periodic-sinc` tests with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. All seventeen fixture loops are exact (0 ULP), as measured over the full fixture set. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01R9yT3mZZw8YXi2JDjpZKth --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../simulate/iter/periodic-sinc/test/test.js | 173 ++---------------- 1 file changed, 18 insertions(+), 155 deletions(-) diff --git a/lib/node_modules/@stdlib/simulate/iter/periodic-sinc/test/test.js b/lib/node_modules/@stdlib/simulate/iter/periodic-sinc/test/test.js index 2a459082265b..5b12ff4508b3 100644 --- a/lib/node_modules/@stdlib/simulate/iter/periodic-sinc/test/test.js +++ b/lib/node_modules/@stdlib/simulate/iter/periodic-sinc/test/test.js @@ -22,11 +22,10 @@ var tape = require( 'tape' ); var proxyquire = require( 'proxyquire' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var iteratorSymbol = require( '@stdlib/symbol/iterator' ); var sinpi = require( '@stdlib/math/base/special/sinpi' ); -var abs = require( '@stdlib/math/base/special/abs' ); var wrap = require( '@stdlib/math/base/special/wrap' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var iterPeriodicSinc = require( './../lib' ); @@ -186,9 +185,7 @@ tape( 'the function throws an error if provided an invalid option', function tes tape( 'the function returns an iterator protocol-compliant object which generates a periodic sinc waveform', function test( t ) { var expected; var actual; - var delta; var tau; - var tol; var phi; var it; var n; @@ -212,13 +209,7 @@ tape( 'the function returns an iterator protocol-compliant object which generate for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -226,10 +217,8 @@ tape( 'the function returns an iterator protocol-compliant object which generate tape( 'the function supports specifying the waveform period (odd N; even period)', function test( t ) { var expected; var actual; - var delta; var opts; var tau; - var tol; var phi; var it; var n; @@ -256,13 +245,7 @@ tape( 'the function supports specifying the waveform period (odd N; even period) for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -270,10 +253,8 @@ tape( 'the function supports specifying the waveform period (odd N; even period) tape( 'the function supports specifying the waveform period (odd N; odd period)', function test( t ) { var expected; var actual; - var delta; var opts; var tau; - var tol; var phi; var it; var n; @@ -300,13 +281,7 @@ tape( 'the function supports specifying the waveform period (odd N; odd period)' for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -314,9 +289,7 @@ tape( 'the function supports specifying the waveform period (odd N; odd period)' tape( 'the function supports specifying the waveform period (even N; even period)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -344,13 +317,7 @@ tape( 'the function supports specifying the waveform period (even N; even period for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -358,9 +325,7 @@ tape( 'the function supports specifying the waveform period (even N; even period tape( 'the function supports specifying the waveform period (even N; odd period)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -388,13 +353,7 @@ tape( 'the function supports specifying the waveform period (even N; odd period) for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -402,9 +361,7 @@ tape( 'the function supports specifying the waveform period (even N; odd period) tape( 'the function supports specifying the wave amplitude (odd N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -435,13 +392,7 @@ tape( 'the function supports specifying the wave amplitude (odd N)', function te for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -449,9 +400,7 @@ tape( 'the function supports specifying the wave amplitude (odd N)', function te tape( 'the function supports specifying the wave amplitude (even N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -482,13 +431,7 @@ tape( 'the function supports specifying the wave amplitude (even N)', function t for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -496,9 +439,7 @@ tape( 'the function supports specifying the wave amplitude (even N)', function t tape( 'the function supports specifying the phase offset (left shift; odd N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -527,13 +468,7 @@ tape( 'the function supports specifying the phase offset (left shift; odd N)', f for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -541,9 +476,7 @@ tape( 'the function supports specifying the phase offset (left shift; odd N)', f tape( 'the function supports specifying the phase offset (left shift; even N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -572,13 +505,7 @@ tape( 'the function supports specifying the phase offset (left shift; even N)', for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -586,9 +513,7 @@ tape( 'the function supports specifying the phase offset (left shift; even N)', tape( 'the function supports specifying the phase offset (left shift; mod; odd N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -617,13 +542,7 @@ tape( 'the function supports specifying the phase offset (left shift; mod; odd N for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -631,9 +550,7 @@ tape( 'the function supports specifying the phase offset (left shift; mod; odd N tape( 'the function supports specifying the phase offset (left shift; mod; even N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -662,13 +579,7 @@ tape( 'the function supports specifying the phase offset (left shift; mod; even for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -676,9 +587,7 @@ tape( 'the function supports specifying the phase offset (left shift; mod; even tape( 'the function supports specifying the phase offset (right shift; odd N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -707,13 +616,7 @@ tape( 'the function supports specifying the phase offset (right shift; odd N)', for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -721,9 +624,7 @@ tape( 'the function supports specifying the phase offset (right shift; odd N)', tape( 'the function supports specifying the phase offset (right shift; even N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -752,13 +653,7 @@ tape( 'the function supports specifying the phase offset (right shift; even N)', for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -766,9 +661,7 @@ tape( 'the function supports specifying the phase offset (right shift; even N)', tape( 'the function supports specifying the phase offset (right shift; mod; odd N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -797,13 +690,7 @@ tape( 'the function supports specifying the phase offset (right shift; mod; odd for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -811,9 +698,7 @@ tape( 'the function supports specifying the phase offset (right shift; mod; odd tape( 'the function supports specifying the phase offset (right shift; mod; even N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -842,13 +727,7 @@ tape( 'the function supports specifying the phase offset (right shift; mod; even for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } t.end(); }); @@ -856,9 +735,7 @@ tape( 'the function supports specifying the phase offset (right shift; mod; even tape( 'the function supports limiting the number of iterations (odd N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -887,13 +764,7 @@ tape( 'the function supports limiting the number of iterations (odd N)', functio for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } actual = it.next(); t.strictEqual( actual.value, void 0, 'returns expected value' ); @@ -905,9 +776,7 @@ tape( 'the function supports limiting the number of iterations (odd N)', functio tape( 'the function supports limiting the number of iterations (even N)', function test( t ) { var expected; var actual; - var delta; var opts; - var tol; var tau; var phi; var it; @@ -936,13 +805,7 @@ tape( 'the function supports limiting the number of iterations (even N)', functi for ( i = 0; i < expected.length; i++ ) { actual = it.next(); t.strictEqual( actual.done, expected[ i ].done, 'returns expected value' ); - if ( actual.value === expected[ i ].value ) { - t.strictEqual( actual.value, expected[ i ].value, 'returns expected value' ); - } else { - delta = abs( actual.value - expected[ i ].value ); - tol = 1.0 * EPS * abs( expected[ i ].value ); - t.strictEqual( delta <= tol, true, 'within tolerance. i: '+i+'. actual: '+actual.value+'. expected: '+expected[ i ].value+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' ); } actual = it.next(); t.strictEqual( actual.value, void 0, 'returns expected value' );