From c172216ea73cfc4bf61a033fdb8e194ee1e22aef Mon Sep 17 00:00:00 2001 From: Aryan Kumar Date: Mon, 21 Sep 2026 12:17:17 -0700 Subject: [PATCH 1/2] test: migrate stats/base/dists/rayleigh/logpdf to ULP-based assertions --- .../rayleigh/logpdf/test/test.factory.js | 33 +++---------------- .../dists/rayleigh/logpdf/test/test.native.js | 33 +++---------------- 2 files changed, 8 insertions(+), 58 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.factory.js index 176f80f46b40..45414efd15ff 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.factory.js @@ -22,10 +22,9 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -129,9 +128,7 @@ tape( 'if `sigma` equals `0`, the created function evaluates a degenerate distri tape( 'the created function evaluates the logpdf for `x` given small scale parameter `sigma`', function test( t ) { var expected; var logpdf; - var delta; var sigma; - var tol; var i; var x; var y; @@ -143,13 +140,7 @@ tape( 'the created function evaluates the logpdf for `x` given small scale param logpdf = factory( sigma[i] ); y = logpdf( x[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 15.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 24 ), true, 'returns expected value' ); } } t.end(); @@ -158,9 +149,7 @@ tape( 'the created function evaluates the logpdf for `x` given small scale param tape( 'the created function evaluates the logpdf for `x` given medium scale parameter `sigma`', function test( t ) { var expected; var logpdf; - var delta; var sigma; - var tol; var i; var x; var y; @@ -172,13 +161,7 @@ tape( 'the created function evaluates the logpdf for `x` given medium scale para logpdf = factory( sigma[i] ); y = logpdf( x[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'returns expected value' ); } } t.end(); @@ -187,9 +170,7 @@ tape( 'the created function evaluates the logpdf for `x` given medium scale para tape( 'the created function evaluates the logpdf for `x` given large scale parameter `sigma`', function test( t ) { var expected; var logpdf; - var delta; var sigma; - var tol; var i; var x; var y; @@ -201,13 +182,7 @@ tape( 'the created function evaluates the logpdf for `x` given large scale param logpdf = factory( sigma[i] ); y = logpdf( x[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.native.js index 05028d9d9328..cf1af5e9e9c4 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.native.js @@ -24,10 +24,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -111,9 +110,7 @@ tape( 'if provided `sigma` equal to `0`, the function evaluates a degenerate dis tape( 'the function evaluates the logpdf for `x` given small scale parameter `sigma`', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var x; var y; @@ -124,13 +121,7 @@ tape( 'the function evaluates the logpdf for `x` given small scale parameter `si for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], sigma[i] ); if ( expected[i] !== null) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 15.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 24 ), true, 'returns expected value' ); } } t.end(); @@ -138,9 +129,7 @@ tape( 'the function evaluates the logpdf for `x` given small scale parameter `si tape( 'the function evaluates the logpdf for `x` given medium scale parameter `sigma`', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var x; var y; @@ -151,13 +140,7 @@ tape( 'the function evaluates the logpdf for `x` given medium scale parameter `s for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], sigma[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'returns expected value' ); } } t.end(); @@ -165,9 +148,7 @@ tape( 'the function evaluates the logpdf for `x` given medium scale parameter `s tape( 'the function evaluates the logpdf for `x` given large scale parameter `sigma`', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var x; var y; @@ -178,13 +159,7 @@ tape( 'the function evaluates the logpdf for `x` given large scale parameter `si for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], sigma[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'returns expected value' ); } } t.end(); From b39fccce8fd949a454a8e5af70a9cbfb02ca06a7 Mon Sep 17 00:00:00 2001 From: Athan Date: Mon, 21 Sep 2026 22:54:07 -0700 Subject: [PATCH 2/2] style: add missing space Signed-off-by: Athan --- .../stats/base/dists/rayleigh/logpdf/test/test.native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.native.js index cf1af5e9e9c4..39fdfceb97a6 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logpdf/test/test.native.js @@ -120,7 +120,7 @@ tape( 'the function evaluates the logpdf for `x` given small scale parameter `si sigma = smallScale.sigma; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], sigma[i] ); - if ( expected[i] !== null) { + if ( expected[i] !== null ) { t.strictEqual( isAlmostSameValue( y, expected[i], 24 ), true, 'returns expected value' ); } }