From 885a1337266d7a2892db6b482656f53bab2ea5ca Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 19 Sep 2026 02:14:54 +0000 Subject: [PATCH] test: migrate `stats/base/dists/uniform/stdev` to ULP-based assertions Replace the relative tolerance (`EPS`-based) assertions in `test/test.js` and `test/test.native.js` with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The maximum observed ULP difference across the full 1000-value Julia fixture set is 1 for both the JavaScript and the native C implementation, so both files use a bound of 1 ULP. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01D74AN8LAoh4Bg1iYcc83dj --- .../@stdlib/stats/base/dists/uniform/stdev/test/test.js | 9 ++------- .../stats/base/dists/uniform/stdev/test/test.native.js | 9 ++------- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/test/test.js index 9cac66399f01..5752ee8e4312 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var stdev = require( './../lib' ); @@ -72,8 +71,6 @@ tape( 'if provided `a >= b`, the function returns `NaN`', function test( t ) { tape( 'the function returns the standard deviation of a uniform distribution', function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -84,9 +81,7 @@ tape( 'the function returns the standard deviation of a uniform distribution', f b = data.b; for ( i = 0; i < expected.length; i++ ) { y = stdev( a[i], b[i] ); - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/test/test.native.js index 667084217552..aad4fbd92114 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -81,8 +80,6 @@ tape( 'if provided `a >= b`, the function returns `NaN`', opts, function test( t tape( 'the function returns the standard deviation of a uniform distribution', opts, function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -93,9 +90,7 @@ tape( 'the function returns the standard deviation of a uniform distribution', o b = data.b; for ( i = 0; i < expected.length; i++ ) { y = stdev( a[i], b[i] ); - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); });