From 277aa42376be7e22a5a5625053880412b4431433 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 18 Sep 2026 02:20:50 +0000 Subject: [PATCH] test: migrate `stats/base/dists/normal/stdev` to ULP-based assertions Replace relative tolerance assertions with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The minimum ULP value which passes over the full fixture set is `0`, as the implementation returns `sigma` exactly. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01PK7gs6ZmFDzvRg4bvGECTM --- .../stats/base/dists/normal/stdev/test/test.js | 13 ++----------- .../base/dists/normal/stdev/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/stdev/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/normal/stdev/test/test.js index 88b4c32d55da..eb86712ec436 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/stdev/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/stdev/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var stdev = require( './../lib' ); @@ -76,9 +75,7 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', function tape( 'the function returns the standard deviation of a normal distribution', function test( t ) { var expected; - var delta; var sigma; - var tol; var mu; var y; var i; @@ -89,13 +86,7 @@ tape( 'the function returns the standard deviation of a normal distribution', fu for ( i = 0; i < mu.length; i++ ) { y = stdev( mu[i], sigma[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/stdev/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/normal/stdev/test/test.native.js index 4074762861fa..5b8eb8b070c3 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/stdev/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/stdev/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -88,9 +87,7 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', opts, fun tape( 'the function returns the standard deviation of a normal distribution', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var mu; var y; var i; @@ -101,13 +98,7 @@ tape( 'the function returns the standard deviation of a normal distribution', op for ( i = 0; i < mu.length; i++ ) { y = stdev( mu[i], sigma[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end();