From 9d6f1d6720ac46017d378a95e3afbde210567fa6 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 17 Sep 2026 21:15:59 +0000 Subject: [PATCH 1/2] test: migrate `stats/base/dists/lognormal/mode` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01KaEmx8PGodkbJvH7CcTJpR --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../stats/base/dists/lognormal/mode/test/test.js | 15 ++++----------- .../base/dists/lognormal/mode/test/test.native.js | 15 ++++----------- 2 files changed, 8 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.js index 6bdd860ab2b3..e642fb0588bc 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.js @@ -22,10 +22,9 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var mode = require( './../lib' ); @@ -76,26 +75,20 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', function tape( 'the function returns the mode of a lognormal distribution', function test( t ) { var expected; - var delta; var sigma; - var tol; + var ULP; var mu; var y; var i; + ULP = 0; expected = data.expected; mu = data.mu; sigma = data.sigma; for ( i = 0; i < mu.length; i++ ) { y = mode( mu[i], sigma[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.native.js index 27ff7d0d2192..3b0dcc87b253 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.native.js @@ -24,10 +24,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -88,26 +87,20 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', opts, fun tape( 'the function returns the mode of a lognormal distribution', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; + var ULP; var mu; var y; var i; + ULP = 0; expected = data.expected; mu = data.mu; sigma = data.sigma; for ( i = 0; i < mu.length; i++ ) { y = mode( mu[i], sigma[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 18.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); } } t.end(); From 1eb09413018c3fe9196f4dd3579ba3ffe7e5abd4 Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 17 Sep 2026 23:28:30 -0700 Subject: [PATCH 2/2] Apply batched suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../@stdlib/stats/base/dists/lognormal/mode/test/test.js | 4 +--- .../stats/base/dists/lognormal/mode/test/test.native.js | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.js index e642fb0588bc..bc3dd3f747b1 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.js @@ -76,19 +76,17 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', function tape( 'the function returns the mode of a lognormal distribution', function test( t ) { var expected; var sigma; - var ULP; var mu; var y; var i; - ULP = 0; expected = data.expected; mu = data.mu; sigma = data.sigma; for ( i = 0; i < mu.length; i++ ) { y = mode( mu[i], sigma[i] ); if ( expected[i] !== null ) { - t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.native.js index 3b0dcc87b253..f3f7a13053f7 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/mode/test/test.native.js @@ -88,19 +88,17 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', opts, fun tape( 'the function returns the mode of a lognormal distribution', opts, function test( t ) { var expected; var sigma; - var ULP; var mu; var y; var i; - ULP = 0; expected = data.expected; mu = data.mu; sigma = data.sigma; for ( i = 0; i < mu.length; i++ ) { y = mode( mu[i], sigma[i] ); if ( expected[i] !== null ) { - t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end();