chore(tests): unit test more conditions

Author: Mat Lord

staxapp/contract.py

@@ -54,7 +54,7 @@ def validate(cls, data, component):
     @staticmethod
     def default_swagger_template() -> dict:
         # Get the default swagger template from https://api.au1.staxapp.cloud/20190206/public/api-document
-        schema = requests.get(Config.schema_url()).json()
+        schema_response = requests.get(Config.schema_url()).json()
         template = dict(
             openapi="3.0.0",
             info={
@@ -75,7 +75,7 @@ def default_swagger_template() -> dict:
                         "x-amazon-apigateway-authtype": "awsSigv4",
                     }
                 },
-                "schemas": schema,
+                "schemas": schema_response.get("components").get("schemas"),
                 "responses": dict(),
                 "requestBodies": dict(),
             },

tests/test_api.py

@@ -207,8 +207,10 @@ def testFailedApiException(self):
             json=response_dict,
             status=500,
         )
-        with self.assertRaises(ApiException):
+        try:
             self.Api.get("/test/no/error")
+        except ApiException as e:
+            self.assertIn("Api Exception", str(e))
 
         # Test an exception which has no json in response
         responses.add(

tests/test_auth.py

@@ -89,7 +89,7 @@ def testCredentialErrors(self):
                 srp_client=self.aws_srp_client,
             )
         except InvalidCredentialsException as e:
-            self.assertIn("Please check your Secret Key is correct", e.message)
+            self.assertIn("Please check your Secret Key is correct", str(e))
             user_not_found_success = True
         self.assertTrue(user_not_found_success)
 
@@ -103,7 +103,7 @@ def testCredentialErrors(self):
         except InvalidCredentialsException as e:
             self.assertIn(
                 "Please check your Access Key, that you have created your Api Token and that you are using the right STAX REGION",
-                e.message,
+                str(e),
             )
             no_access_success = True
         self.assertTrue(no_access_success)

tests/test_client.py

@@ -36,6 +36,13 @@ def testStaxClient(self):
         self.assertTrue(client._initialized)
         self.assertTrue(client._admin)
 
+    def testInvalidStaxClient(self):
+        """
+        Test an invalid Api class raises an error
+        """
+        with self.assertRaises(ValidationException):
+            StaxClient("fake")
+
     def testLoadLiveSchema(self):
         """
         Test loading live schema

tests/test_contract.py

@@ -19,6 +19,17 @@ class StaxContractTests(unittest.TestCase):
     def setUp(self):
         self.StaxContract = StaxContract
 
+    def testInvalidSchema(self):
+        """
+        Test an error is thrown if no schema is found
+        """
+        sc = StaxContract
+        sc._swagger_doc = None
+        data = {"Name": "Unit", "AccountType": "Test"}
+        component = "accounts.CreateAccount"
+        sc.validate(data, component)
+        self.assertIsNotNone(sc._swagger_doc)
+
     def testDefaultSchema(self):
         """
         Test the default schema is valid