feat(sdk): make clients immutable

make clients immutable
fix inconsistent default

Author: ZXYmania

staxapp/api.py

@@ -8,7 +8,7 @@
 
 class Api:
     @classmethod
-    def get_config(cls, config=None, **kwargs):
+    def get_config(cls, config=None):
         if config is None:
             config = Config.GetDefaultConfig()
         return config

staxapp/auth.py

@@ -61,6 +61,7 @@ def id_token_from_cognito(
             client_id=self.client_id,
             client=srp_client,
         )
+
         try:
             tokens = aws.authenticate_user()
         except ClientError as e:

staxapp/config.py

@@ -1,6 +1,8 @@
 import logging
 import os
 import platform as sysinfo
+from distutils.command.config import config
+from email.policy import default
 
 import requests
 
@@ -23,13 +25,13 @@ class Config:
     access_key = None
     secret_key = None
     auth_class = None
+    auth = None
     _requests_auth = None
     _initialized = False
     base_url = None
     _hostname = f"api.{STAX_REGION}"
     hostname = None
     org_id = None
-    auth = None
     expiration = None
     load_live_schema = True
 
@@ -59,14 +61,16 @@ def get_api_config(cls, config_url):
         cls.cached_api_config["caching"] = config_url
         return config_response.json()
 
-    def init(self, hostname=None):
-        if self._initialized:
-            return
+    def __init__(self, hostname=None, access_key=None, secret_key=None):
+        self.hostname = hostname
         if self.hostname is None:
-            self.hostname = hostname
-            if self.hostname is None:
-                self.hostname = Config._hostname
+            self.hostname = Config._hostname
+        self.access_key = access_key
+        self.secret_key = secret_key
 
+    def init(self):
+        if self._initialized:
+            return
         self.set_config()
 
         self._initialized = True
@@ -81,7 +85,7 @@ def api_base_url(self):
 
     @classmethod
     def GetDefaultConfig(cls):
-        config = Config()
+        config = Config(Config.hostname, Config.access_key, Config.secret_key)
         return config
 
     def branch(cls):

staxapp/openapi.py

@@ -19,10 +19,16 @@ class StaxClient:
     def _get_config(self):
         return self._config
 
-    def __init__(self, classname, force=False, config=Config.GetDefaultConfig()):
+    def __init__(self, classname, force=False, config=None):
         # Stax feature, eg 'quotas', 'workloads'
-        self._config = config
-        if not config._initialized:
+        if config is None:
+            config = Config.GetDefaultConfig()
+        self._config = Config(
+            hostname=config.hostname,
+            access_key=config.access_key,
+            secret_key=config.secret_key,
+        )
+        if not self._config._initialized:
             self._config.init()
 
         if force or not self._operation_map:

tests/test_config.py

@@ -29,8 +29,8 @@ def testInit(self, set_config_mock):
         Test init method
         """
         test_hostname = "test.staxapp.cloud"
-        config = Config()
-        config.init(hostname=test_hostname)
+        config = Config(hostname=test_hostname)
+        config.init()
         self.assertEqual(
             test_hostname,
             config.hostname,