Skip to content

Commit fd70564

Browse files
committed
Merge branch '3.5.x' into 4.0.x
Closes gh-50176
2 parents f8bb816 + 4b0862c commit fd70564

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

module/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/remote/server/HttpHeaderAccessManager.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616

1717
package org.springframework.boot.devtools.remote.server;
1818

19+
import java.nio.charset.StandardCharsets;
20+
import java.security.MessageDigest;
21+
1922
import org.springframework.http.server.ServerHttpRequest;
2023
import org.springframework.util.Assert;
2124

@@ -30,19 +33,20 @@ public class HttpHeaderAccessManager implements AccessManager {
3033

3134
private final String headerName;
3235

33-
private final String expectedSecret;
36+
private final byte[] expectedSecret;
3437

3538
public HttpHeaderAccessManager(String headerName, String expectedSecret) {
3639
Assert.hasLength(headerName, "'headerName' must not be empty");
3740
Assert.hasLength(expectedSecret, "'expectedSecret' must not be empty");
3841
this.headerName = headerName;
39-
this.expectedSecret = expectedSecret;
42+
this.expectedSecret = expectedSecret.getBytes(StandardCharsets.UTF_8);
4043
}
4144

4245
@Override
4346
public boolean isAllowed(ServerHttpRequest request) {
4447
String providedSecret = request.getHeaders().getFirst(this.headerName);
45-
return this.expectedSecret.equals(providedSecret);
48+
return (providedSecret != null)
49+
&& MessageDigest.isEqual(providedSecret.getBytes(StandardCharsets.UTF_8), this.expectedSecret);
4650
}
4751

4852
}

0 commit comments

Comments
 (0)