Add nullability annotations to tests in module/spring-boot-rsocket

See gh-47263

Author: mhalbritter

module/spring-boot-rsocket/build.gradle

@@ -43,5 +43,11 @@ dependencies {
 	testImplementation("io.projectreactor:reactor-test")
 	testImplementation("org.springframework:spring-webflux")
 
+	testCompileOnly("com.google.code.findbugs:jsr305")
+
 	testRuntimeOnly("ch.qos.logback:logback-classic")
 }
+
+tasks.named("compileTestJava") {
+	options.nullability.checking = "tests"
+}

module/spring-boot-rsocket/src/test/java/org/springframework/boot/rsocket/autoconfigure/RSocketMessagingAutoConfigurationTests.java

@@ -65,7 +65,9 @@ void shouldFailOnMissingStrategies() {
 		new ApplicationContextRunner().withConfiguration(AutoConfigurations.of(RSocketMessagingAutoConfiguration.class))
 			.run((context) -> {
 				assertThat(context).hasFailed();
-				assertThat(context.getStartupFailure().getMessage()).contains("No qualifying bean of type "
+				Throwable startupFailure = context.getStartupFailure();
+				assertThat(startupFailure).isNotNull();
+				assertThat(startupFailure.getMessage()).contains("No qualifying bean of type "
 						+ "'org.springframework.messaging.rsocket.RSocketStrategies' available");
 			});
 	}
@@ -90,7 +92,9 @@ void shouldRegisterControllerAdvice() {
 		this.contextRunner.withBean(TestControllerAdvice.class).withBean(TestController.class).run((context) -> {
 			RSocketMessageHandler handler = context.getBean(RSocketMessageHandler.class);
 			MessageHeaderAccessor headers = new MessageHeaderAccessor();
-			RouteMatcher.Route route = handler.getRouteMatcher().parseRoute("exception");
+			RouteMatcher routeMatcher = handler.getRouteMatcher();
+			assertThat(routeMatcher).isNotNull();
+			RouteMatcher.Route route = routeMatcher.parseRoute("exception");
 			headers.setHeader(DestinationPatternsMessageCondition.LOOKUP_DESTINATION_HEADER, route);
 			headers.setHeader(RSocketFrameTypeMessageCondition.FRAME_TYPE_HEADER, FrameType.REQUEST_FNF);
 			Message<?> message = MessageBuilder.createMessage(Mono.empty(), headers.getMessageHeaders());

module/spring-boot-rsocket/src/test/java/org/springframework/boot/rsocket/autoconfigure/RSocketWebSocketNettyRouteProviderTests.java

@@ -19,6 +19,7 @@
 import java.net.URI;
 import java.time.Duration;
 
+import org.jspecify.annotations.Nullable;
 import org.junit.jupiter.api.Test;
 import tools.jackson.databind.json.JsonMapper;
 
@@ -67,13 +68,16 @@ void webEndpointsShouldWork() {
 			.run((context) -> {
 				ReactiveWebServerApplicationContext serverContext = (ReactiveWebServerApplicationContext) context
 					.getSourceApplicationContext();
-				RSocketRequester requester = createRSocketRequester(context, serverContext.getWebServer());
+				WebServer webServer = serverContext.getWebServer();
+				assertThat(webServer).isNotNull();
+				RSocketRequester requester = createRSocketRequester(context, webServer);
 				TestProtocol rsocketResponse = requester.route("websocket")
 					.data(new TestProtocol("rsocket"))
 					.retrieveMono(TestProtocol.class)
 					.block(Duration.ofSeconds(3));
+				assertThat(rsocketResponse).isNotNull();
 				assertThat(rsocketResponse.getName()).isEqualTo("rsocket");
-				WebTestClient client = createWebTestClient(serverContext.getWebServer());
+				WebTestClient client = createWebTestClient(webServer);
 				client.get()
 					.uri("/protocol")
 					.exchange()
@@ -150,20 +154,20 @@ TestProtocol testRSocketEndpoint() {
 
 	public static class TestProtocol {
 
-		private String name;
+		private @Nullable String name;
 
 		TestProtocol() {
 		}
 
-		TestProtocol(String name) {
+		TestProtocol(@Nullable String name) {
 			this.name = name;
 		}
 
-		public String getName() {
+		public @Nullable String getName() {
 			return this.name;
 		}
 
-		public void setName(String name) {
+		public void setName(@Nullable String name) {
 			this.name = name;
 		}
 

module/spring-boot-rsocket/src/test/java/org/springframework/boot/rsocket/netty/NettyRSocketServerFactoryTests.java

@@ -32,7 +32,7 @@
 import io.rsocket.transport.netty.client.TcpClientTransport;
 import io.rsocket.transport.netty.client.WebsocketClientTransport;
 import io.rsocket.util.DefaultPayload;
-import org.assertj.core.api.Assertions;
+import org.jspecify.annotations.Nullable;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.InOrder;
@@ -79,9 +79,9 @@
  */
 class NettyRSocketServerFactoryTests {
 
-	private NettyRSocketServer server;
+	private @Nullable NettyRSocketServer server;
 
-	private RSocketRequester requester;
+	private @Nullable RSocketRequester requester;
 
 	@AfterEach
 	void tearDown() {
@@ -111,10 +111,15 @@ void specificPort() {
 			factory.setPort(0);
 			this.server = factory.create(new EchoRequestResponseAcceptor());
 			this.server.start();
-			return this.server.address().getPort();
+			InetSocketAddress address = this.server.address();
+			assertThat(address).isNotNull();
+			return address.getPort();
 		});
 		this.requester = createRSocketTcpClient();
-		assertThat(this.server.address().getPort()).isEqualTo(specificPort);
+		assertThat(this.server).isNotNull();
+		InetSocketAddress address = this.server.address();
+		assertThat(address).isNotNull();
+		assertThat(address.getPort()).isEqualTo(specificPort);
 		checkEchoRequest();
 	}
 
@@ -264,6 +269,7 @@ void websocketTransportBasicSslCertificateFromFileSystemWithBundle(@ResourcePath
 
 	private void checkEchoRequest() {
 		String payload = "test payload";
+		assertThat(this.requester).isNotNull();
 		Mono<String> response = this.requester.route("test").data(payload).retrieveMono(String.class);
 		StepVerifier.create(response).expectNext(payload).expectComplete().verify(Duration.ofSeconds(30));
 	}
@@ -375,8 +381,9 @@ private HttpClient createSecureHttpClient() {
 	}
 
 	private HttpClient createHttpClient() {
-		Assertions.assertThat(this.server).isNotNull();
+		assertThat(this.server).isNotNull();
 		InetSocketAddress address = this.server.address();
+		assertThat(address).isNotNull();
 		return HttpClient.create().host(address.getHostName()).port(address.getPort());
 	}
 
@@ -389,8 +396,9 @@ private TcpClient createSecureTcpClient() {
 	}
 
 	private TcpClient createTcpClient() {
-		Assertions.assertThat(this.server).isNotNull();
+		assertThat(this.server).isNotNull();
 		InetSocketAddress address = this.server.address();
+		assertThat(address).isNotNull();
 		return TcpClient.create().host(address.getHostName()).port(address.getPort());
 	}