Skip to content

SUGGESTION: Critical ambiguity in Symbol/Period declaration #11

@celestynuno-cmyk

Description

@celestynuno-cmyk

Hi @amusleh-spotware-com ,

I noticed a redundancy in Symbol and Period declarations that can lead to user error.

My Findings:

  • Declaration: Values can be set via Environment Variables OR .cbotset files, which is okay.
  • Double Declaration: The current image allows conflicting configurations to exist simultaneously within .cbotset and as Environment Variables.
  • Hierarchy: In case of double declaration, .cbotset takes precedence without warning.

My Suggestion:

  • Atomic Configuration: The .cbotset file should always contain both or none of these variables.
  • Mutual Exclusivity: If .cbotset has values, declaring them as Environment Variables should not be allowed. The container should fail to start, throwing a configuration error.
  • Fallback: If .cbotset is empty, both Environment Variables must be mandatory.

This would prevent users from accidentally running a bot on the wrong symbol/period due to a configuration override.
Am I missing a specific reason for the current logic, maybe?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions