feat(settings): enlarge Settings modal and align stacked sub-modal scrim#300
Merged
Conversation
960x680 Notion-style frame with the sidebar "Settings" heading lifted to match the right pane title baseline — both at text-xl semibold so the left/right columns share a single horizontal heading strip instead of one big title floating above a small label. Content padding bumped to px-16 for breathing room at the new width; the close-X and nav row font sizes were nudged to keep weights balanced against the bigger title. AllowlistManageModal (the only sub-modal that actually stacks inside Settings today) gets the matching Notion treatment: anchors at pt-[15vh] instead of viewport center so it lines up with where the Settings content begins, widens 560 -> 720 for proportional scale against the parent, and uses a deeper warm-text/50 + black/65 + backdrop-blur-md scrim. The two scrims compound naturally — outer Settings goes monochrome behind it, focus snaps to the inner dialog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
text-xl font-semiboldand lifted topt-8— same baseline as the right-pane section title (通用/安全/ etc.), so the two columns share one heading strip instead of one big title floating beside a small kickerpt-[15vh]instead of viewport center, scrim deepened tobg-warm-text/50 dark:bg-black/65+backdrop-blur-mdWhy
Two pain points the user surfaced while dogfooding the Security pane:
pt-[15vh]matches where the Settings content actually starts, and the deeper compound scrim (outer Settings panel goes monochrome behind it) snaps focus to the inner dialog the way Notion's stacking pattern does.How it connects
Sets the pattern for future sub-modals inside Settings — PF first-time education modal (deferred) and the Source-JSONL Restore confirm (planned as part of source-file redaction GA blocker) will both render through this same stacking convention, so the visual layering decision is locked in once instead of being re-negotiated per modal.
Test plan