noprint wrapped sections still appear in the output PDF

[cjohnsonuk]

I have page metadata table at the bottom of some my document pages and a review record form that should appear on the page viewed online (so people can see and add reviews) but not appear when the page is exported to PDF using DW2pdf. This used to work, I have many examples of PDFs created this way but now even if I wrap my markup in

nonprinting content it still appears in the PDF.

I don't think this coincided with the upgrade to Mort but I've not used dw2PDF for some time so I can't be sure.

Testing

I rantail -f /var/log/apache2/error.log to search for errors but there were only PHP warnings about "Undefined array key" in adauth

I've created a new wiki on the same server, (ubuntu and apache).
I've copied the data folder across and the plugins folder
I've gone through and

1. disabled plugins in groups (by first letter)
2. touched the ./conf/local.php file to force ignoring the cache
3. Edited the page, adding a manually entered timestamp, saved and reloaded the page
4. exported to PDF using DW2pdf and the default bundled template
   I repeated this process until all non default plugins were disabled and still got the same problem

Stage 2
I created a new wiki again on the same server
I added only the DW2PDF plugin with a clean install so no link to the existing wiki nor its data
I created a test page and marked some of it as no print but it still printed

Stage 3
I created a new wiki again on a laptop with a new install of apache and php
I added only the DW2PDF plugin with a clean install so no link to the existing wiki nor its data nor the same apache configs
I created a test page and marked some of it as no print but it still printed to PDF

Expected behaviour content wrapped in no print wrappers should not appear in the dw2pdf exported content

[Klap-in]

The noprint sections have probably a css class? If you enable allowdebug setting in DokuWiki, then you can add &debug=1 to the url to get the html and css. If you look at the source of that view you can see how the html and css look like and if it relates. Dw2pdf plugin have had a big update so maybe that had an unintended side effect..

[cjohnsonuk]

Additional testing: The test page now consists of all the following markup

~~NOCACHE~~

====== Non Printing Section Test ======

=====Summary=====
This page is to test printing and non printing sections and has been extended to test all wrap functions when used with DW2PDF plugin.



===== Test area =====
/* Use this section to test out wiki syntax */

==== Printing section ====

this should print

Pagebreak plugin page break here:
<pagebreak>
Top of next page

==== Only Printing section ====

<WRAP onlyprint>
this should appear in print but not in web view
</WRAP>

Pagebreak plugin page break here:
<pagebreak>
Top of next page

==== Wrap test section ====

<WRAP info>
this should print in an info 
</WRAP>

<WRAP alert>
this should print in an alert 
</WRAP>

this should print in an inline <wrap info>info</wrap>

this should print in an inline <wrap danger>danger</wrap>

this should print in an inline <wrap alert>alert</wrap>

<WRAP leftalign>
this should align left
</WRAP>

<WRAP centeralign>
this should align center
</WRAP>

<WRAP rightalign>
this should align right
</WRAP>

<WRAP justify>
this should justify text.  this should justify text.  this should justify text.  
</WRAP>

=== The following should be in 2 columns. ===

<WRAP col2>
this should be in 2 columns.  Lorem ipsum dolor sit amet, consectetur adipiscing elit. 
Proin vel dui tellus. 
Ut ac mi vitae risus hendrerit lacinia. 
Etiam a bibendum diam, eu fermentum libero. 
Morbi elit neque, commodo sed cursus ut, suscipit sed nulla. 
Maecenas malesuada molestie elit ut iaculis. 
Nam sollicitudin rhoncus neque eu congue. 
Vivamus sit amet sapien sodales, molestie massa sed, efficitur magna. 
Donec felis augue, molestie in eros sed, fringilla fringilla arcu. 
Vestibulum pretium leo sodales est tincidunt hendrerit. 
Donec dapibus non lectus a ultricies. 
Suspendisse sit amet odio mattis, consectetur nisl eget, maximus nunc. 
Suspendisse lacus nulla, aliquet id ex in, tristique congue lectus. 
Curabitur sagittis pretium quam. 
Lorem ipsum dolor sit amet, consectetur adipiscing elit.
end of 2 columns
</WRAP>


=== The following should be in 3 columns. ===
 

<WRAP col3>
this should be in 3 columns.  Lorem ipsum dolor sit amet, consectetur adipiscing elit. 
Proin vel dui tellus. 
Ut ac mi vitae risus hendrerit lacinia. 
Etiam a bibendum diam, eu fermentum libero. 
Morbi elit neque, commodo sed cursus ut, suscipit sed nulla. 
Maecenas malesuada molestie elit ut iaculis. 
Nam sollicitudin rhoncus neque eu congue. 
Vivamus sit amet sapien sodales, molestie massa sed, efficitur magna. 
Donec felis augue, molestie in eros sed, fringilla fringilla arcu. 
Vestibulum pretium leo sodales est tincidunt hendrerit. 
Donec dapibus non lectus a ultricies. 
Suspendisse sit amet odio mattis, consectetur nisl eget, maximus nunc. 
Suspendisse lacus nulla, aliquet id ex in, tristique congue lectus. 
Curabitur sagittis pretium quam. 
Lorem ipsum dolor sit amet, consectetur adipiscing elit.
end of 3 columns
</WRAP>

=== The following should be in 2 columns justified. ===

this should be in 2 columns.  Lorem ipsum dolor sit amet, consectetur adipiscing elit. 
Proin vel dui tellus. 
Ut ac mi vitae risus hendrerit lacinia. 
Etiam a bibendum diam, eu fermentum libero. 
Morbi elit neque, commodo sed cursus ut, suscipit sed nulla. 
Maecenas malesuada molestie elit ut iaculis. 
Nam sollicitudin rhoncus neque eu congue. 
Vivamus sit amet sapien sodales, molestie massa sed, efficitur magna. 
Donec felis augue, molestie in eros sed, fringilla fringilla arcu. 
Vestibulum pretium leo sodales est tincidunt hendrerit. 
Donec dapibus non lectus a ultricies. 
Suspendisse sit amet odio mattis, consectetur nisl eget, maximus nunc. 
Suspendisse lacus nulla, aliquet id ex in, tristique congue lectus. 
Curabitur sagittis pretium quam. 
Lorem ipsum dolor sit amet, consectetur adipiscing elit.
end of 2 columns
</WRAP>

=== The following should be in 2 columns right aligned. ===

<WRAP col2 rightalign>
this should be in 2 columns.  Lorem ipsum dolor sit amet, consectetur adipiscing elit. 
Proin vel dui tellus. 
Ut ac mi vitae risus hendrerit lacinia. 
Etiam a bibendum diam, eu fermentum libero. 
Morbi elit neque, commodo sed cursus ut, suscipit sed nulla. 
Maecenas malesuada molestie elit ut iaculis. 
Nam sollicitudin rhoncus neque eu congue. 
Vivamus sit amet sapien sodales, molestie massa sed, efficitur magna. 
Donec felis augue, molestie in eros sed, fringilla fringilla arcu. 
Vestibulum pretium leo sodales est tincidunt hendrerit. 
Donec dapibus non lectus a ultricies. 
Suspendisse sit amet odio mattis, consectetur nisl eget, maximus nunc. 
Suspendisse lacus nulla, aliquet id ex in, tristique congue lectus. 
Curabitur sagittis pretium quam. 
Lorem ipsum dolor sit amet, consectetur adipiscing elit.
end of 2 columns
</WRAP>

=== The following should be in 2 columns center aligned. ===

<WRAP col2 centeralign>
this should be in 2 columns.  Lorem ipsum dolor sit amet, consectetur adipiscing elit. 
Proin vel dui tellus. 
Ut ac mi vitae risus hendrerit lacinia. 
Etiam a bibendum diam, eu fermentum libero. 
Morbi elit neque, commodo sed cursus ut, suscipit sed nulla. 
Maecenas malesuada molestie elit ut iaculis. 
Nam sollicitudin rhoncus neque eu congue. 
Vivamus sit amet sapien sodales, molestie massa sed, efficitur magna. 
Donec felis augue, molestie in eros sed, fringilla fringilla arcu. 
Vestibulum pretium leo sodales est tincidunt hendrerit. 
Donec dapibus non lectus a ultricies. 
Suspendisse sit amet odio mattis, consectetur nisl eget, maximus nunc. 
Suspendisse lacus nulla, aliquet id ex in, tristique congue lectus. 
Curabitur sagittis pretium quam. 
Lorem ipsum dolor sit amet, consectetur adipiscing elit.
end of 2 columns
</WRAP>

Pagebreak plugin page break here:
<pagebreak>
Top of next page
==== No Print wrap with a title ====

Should be no Lorem below in the PDF
<WRAP noprint>

=== Non printing Headline ===

Lorem ipsum dolor sit amet, consectetur adipiscing elit. 
Proin vel dui tellus. 
Ut ac mi vitae risus hendrerit lacinia. 
Etiam a bibendum diam, eu fermentum libero. 
Morbi elit neque, commodo sed cursus ut, suscipit sed nulla. 
Maecenas malesuada molestie elit ut iaculis. 
Nam sollicitudin rhoncus neque eu congue. 
Vivamus sit amet sapien sodales, molestie massa sed, efficitur magna. 
Donec felis augue, molestie in eros sed, fringilla fringilla arcu. 
Vestibulum pretium leo sodales est tincidunt hendrerit. 
Donec dapibus non lectus a ultricies. 
Suspendisse sit amet odio mattis, consectetur nisl eget, maximus nunc. 
Suspendisse lacus nulla, aliquet id ex in, tristique congue lectus. 
Curabitur sagittis pretium quam. 
Lorem ipsum dolor sit amet, consectetur adipiscing elit.


</WRAP>
Should be no Lorem above

WRAP plugin page break here
<WRAP pagebreak></WRAP>
Top of next page

==== No print wrap without  a title ====

=== No Lorem here ===
Should be no Lorem below in the PDF
<WRAP noprint>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. 
Proin vel dui tellus. 
Ut ac mi vitae risus hendrerit lacinia. 
Etiam a bibendum diam, eu fermentum libero. 
Morbi elit neque, commodo sed cursus ut, suscipit sed nulla. 
Maecenas malesuada molestie elit ut iaculis. 
Nam sollicitudin rhoncus neque eu congue. 
Vivamus sit amet sapien sodales, molestie massa sed, efficitur magna. 
Donec felis augue, molestie in eros sed, fringilla fringilla arcu. 
Vestibulum pretium leo sodales est tincidunt hendrerit. 
Donec dapibus non lectus a ultricies. 
Suspendisse sit amet odio mattis, consectetur nisl eget, maximus nunc. 
Suspendisse lacus nulla, aliquet id ex in, tristique congue lectus. 
Curabitur sagittis pretium quam. 
Lorem ipsum dolor sit amet, consectetur adipiscing elit.


</WRAP>

Should be no Lorem above


==== Everything here prints ====

this lorem text should appear in PDF

Lorem ipsum dolor sit amet, consectetur adipiscing elit. 
Proin vel dui tellus. 
Ut ac mi vitae risus hendrerit lacinia. 
Etiam a bibendum diam, eu fermentum libero. 
Morbi elit neque, commodo sed cursus ut, suscipit sed nulla. 
Maecenas malesuada molestie elit ut iaculis. 
Nam sollicitudin rhoncus neque eu congue. 
Vivamus sit amet sapien sodales, molestie massa sed, efficitur magna. 
Donec felis augue, molestie in eros sed, fringilla fringilla arcu. 
Vestibulum pretium leo sodales est tincidunt hendrerit. 
Donec dapibus non lectus a ultricies. 
Suspendisse sit amet odio mattis, consectetur nisl eget, maximus nunc. 
Suspendisse lacus nulla, aliquet id ex in, tristique congue lectus. 
Curabitur sagittis pretium quam. 
Lorem ipsum dolor sit amet, consectetur adipiscing elit.

None of the inline wrap or block WRAP formatting gets into the exported PDF. No info boxes, no multiple columns, no text justification, no wrap page breaks.

Pagebreak plugin pagebreaks do work.

I've enabled debug in the conf and added ?do=debug to the URL and got a huge page of settings but nothing stands out in that.

I added ?debug=1 to the URL and viewed the source and got html including the following

<p>
Should be no Lorem below
</p>
<div class="wrap_noprint plugin_wrap">
<h4 id="non_printing_headline">Non printing Headline</h4>

<p>
Lorem ipsum dolor sit amet, consectetur adipiscing elit.
Proin vel dui tellus.
Ut ac mi vitae risus hendrerit lacinia.
Etiam a bibendum diam, eu fermentum libero.
Morbi elit neque, commodo sed cursus ut, suscipit sed nulla.
Maecenas malesuada molestie elit ut iaculis.
Nam sollicitudin rhoncus neque eu congue.
Vivamus sit amet sapien sodales, molestie massa sed, efficitur magna.
Donec felis augue, molestie in eros sed, fringilla fringilla arcu.
Vestibulum pretium leo sodales est tincidunt hendrerit.
Donec dapibus non lectus a ultricies.
Suspendisse sit amet odio mattis, consectetur nisl eget, maximus nunc.
Suspendisse lacus nulla, aliquet id ex in, tristique congue lectus.
Curabitur sagittis pretium quam.
Lorem ipsum dolor sit amet, consectetur adipiscing elit.
</p>
</div>
<p>
Should be no Lorem above
</p>

<p>
Pagebreak here
</p>
<div class="wrap_pagebreak plugin_wrap"></div>
<p>
Top of next page
</p>

but the lorem text appears in the PDF.

The pagebreak doesn't work in the PDF when using the <WRAP pagebreak></WRAP> markup but does work when using the <pagebreak> plugin markup.

Adding debug to the URL like this test_print?do=export_pdf&debug=1 the page and all the formatting appears in the browser with the formatting showing as expected. Viewing source shows that pagebreak plugin page breaks appear as

<p>
Pagebreak plugin page break here:
<pagebreak />
Top of next page
</p>

and wrap plugin page breaks appear as

<p>
WRAP plugin page break here
</p>
<!-- EDIT{&quot;target&quot;:&quot;plugin_wrap_start&quot;,&quot;hid&quot;:&quot;&quot;,&quot;secid&quot;:25,&quot;range&quot;:&quot;0-&quot;} --><div class="wrap_pagebreak plugin_wrap"></div><!-- EDIT{&quot;target&quot;:&quot;plugin_wrap_end&quot;,&quot;hid&quot;:&quot;&quot;,&quot;secid&quot;:26,&quot;range&quot;:&quot;0-&quot;} -->
<p>
Top of next page
</p>

There are similar !<-- ... --> comments with all the wrap markup.

The page source shows css styling including

.dokuwiki .wrap_pagebreak {
  break-after: page;
  page-break-after: always;
}
.dokuwiki .wrap_nopagebreak {
  break-inside: avoid;
  page-break-inside: avoid;
}
.dokuwiki .wrap_noprint {
  display: none;
}
.dokuwiki div.wrap_onlyprint {
  display: block;
}

in the debug output of the html for the do=export_pdf the text of the non printing sections are in the source but are styled so that they don't appear on the web page. All the other formatting, boxes, columns, justification all work as expected in the debug 'preview'. It would appear that its something in the DW2PDF that it not taking these styles into account.

[cjohnsonuk]

One more additional test that might help
I've copied a version of the DW2pdf plugin folder with a plugin dated 2023-11-25 (plugininfo) in place of the latest one. Nothing else in the test changed.
Now when creating a PDF the non printing sections are hidden from the PDF correctly.
The coloured boxes and inline highlighting appear (although their associated icons are missing).
Aligned text appears in the PDF with the expected justification
Page breaks for both pagebreak and wrap breaks appear in the PDF as expected

Wrap styled Multiple column text does not appear in multiple columns in the PDF.

Is it possible to roll back my version of DW2PDF to the one immediately prior to the rewrite just to allow me to export my docs to PDF? The releases in github seem to relate to updated linked to MDPF rather than releases of DW2PDF. I've used github for years, superficially, but not enough to know how to get access to the code from a particular date

[Klap-in]

The tags are made for smaller increments, see https://github.com/splitbrain/dokuwiki-plugin-dw2pdf/tags I guess the tag of January is probably what you need for now?

[cjohnsonuk]

Thanks. I'll give that a try.
Are you able to confirm if this is a bug with the plugin or just an issue with my instance?

[cjohnsonuk]

January tagged version works as expected. Thanks for the help finding where to get it from ! :-)

[Klap-in]

I did not have the opportunity to test it yet with real code. Looking at your wiki syntax example, it looks like testing only with dw2pdf and wrap plugin are enough to reproduce it?

[cjohnsonuk]

Yes. I did a clean install of a new wiki and just added dw2pdf plugin, ( wrap was part of the original download) to check that the tweaks I made to plugins weren't affecting anything. (I tweaked DW2PDF to remove links to local/internal servers prior to creating a PDF so external readers of the PDF don't get links that don't work

One additional point to note, even on the January release there are issues where noprint wraps do not work if there are numbered headings (=== - Numbered heading ===) within the section... but not always. I've yet to work out the pattern there