You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c9ae70d
Browse filesBrowse the repository at this point in the historyBrowse files
fix(release,packaging): prep Docker for release parity, fail-closed packaging, hermetic gitroot test
Addresses four findings:
4. The release gate did not prepare Docker like the main workflow. release.yml's
gate-runtime ran `task parity:runtime` without enabling the containerd image
store, so its build-cache-export precondition fails on a default-driver runner
and a tagged release stalls. Added the same "free disk + containerd store" step
the go-cli.yml runtime job uses.
7. The release did not run OCI publish parity. `task parity:publish` runs only on
the daily schedule, so a tag could ship a regression in features/templates
publish. Added it to gate-runtime after parity:runtime.
5. Packaging could report success without valid metadata. writeCollectionMetadata
discarded both the serialize and the write error, and its callers returned
success — a full disk / read-only output produced an incomplete package with a
success message. It now returns an error that packageCollection and
packageSingleItem propagate; publishCollectionWith also checks the previously
ignored MkdirTemp error (which left tmpDir="" and scattered artifacts into cwd).
8. Environment-dependent temp-dir test. TestDetectGitRootNotARepo assumed no
ancestor of t.TempDir() held a `.git`, and failed when /tmp was itself a repo.
Split detectGitRoot into a bounded detectGitRootUntil(dir, ceiling) so the walk
can stop at an isolated root; the test now bounds the search and a new case
asserts a `.git` above the ceiling is not found while the unbounded walk finds it.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
0 commit comments