You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 83b9ad4
Browse filesBrowse the repository at this point in the historyBrowse files
test(parity): lock the cases whose setup writes Features
TestParityMatrixLocksTheFeatureContentImage read Features only from
fixture configurations, so 13 cases whose setup_cmd writes a
configuration with Features and builds it without BuildKit ran
without the feature-content-image lock and could take each other's
Features through dev_container_feature_content_temp. The check now
also reads the configuration a setup_cmd writes, and those cases hold
the lock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: docs/parity/parity-matrix.yaml
+13Lines changed: 13 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -780,6 +780,7 @@ initial_cases:
780
780
notes: "TS builds a Dockerfile service through a build override even without Features (getImageBuildOptions adds the devcontainer.metadata label to the image) and then runs updateRemoteUserUID on the built image (dockerCompose.ts startContainer). Go built the service unchanged and never remapped the remote user's UID for compose."
notes: "BuildKit Features build (TS getFeaturesBuildOptions + getFeatureLayers, containerFeaturesConfiguration.ts): the Feature is staged at its consecutiveId (hello_0), bind-mounted from the dev_containers_feature_content_source build context, copied to /tmp/dev-container-features/hello_0 and installed through devcontainer-features-install.sh, which sources ../devcontainer-features.builtin.env (_CONTAINER_USER/_REMOTE_USER plus the _*_HOME lines the first RUN appends) and devcontainer-features.env (options in devcontainer-feature.json order); the folder is removed afterwards, the builtin env stays. The Feature's containerEnv and the config's containerEnv are ENV lines and the image keeps its own user (USER $_DEV_CONTAINERS_IMAGE_USER). Go used to copy _dev_container_feature_0 to /tmp/build-features and run install.sh with inline env prefixes, so ../devcontainer-features.builtin.env did not exist."
notes: "A compose configuration without workspaceFolder works in `/` (TS getWorkspaceConfiguration returns getRemoteWorkspaceFolder, `config.workspaceFolder || '/'`, dockerCompose.ts): up's remoteWorkspaceFolder, ${containerWorkspaceFolder}, the lifecycle commands' cwd and exec's cwd. Go used /workspaces/<basename>, a folder the compose service never mounts."
1099
1101
1100
1102
- id: build.frozen-lockfile-missing-failure
1103
+
lock: feature-content-image
1101
1104
lane: runtime
1102
1105
command: build
1103
1106
priority: p1
@@ -1111,6 +1114,7 @@ initial_cases:
1111
1114
notes: "--frozen-lockfile without a lockfile fails with TS writeLockfile's 'Lockfile does not exist.' (lockfile.ts), wrapped as the build's ContainerError: message is that text, description 'An error occurred building the container.'. Go skipped the check when no lockfile existed and built the image."
1112
1115
1113
1116
- id: up.frozen-lockfile-mismatch-failure
1117
+
lock: feature-content-image
1114
1118
lane: runtime
1115
1119
command: up
1116
1120
priority: p1
@@ -1124,6 +1128,7 @@ initial_cases:
1124
1128
notes: "A stale lockfile with --frozen-lockfile fails with TS's 'Lockfile does not match.' as the message and 'An error occurred setting up the container.' as the description. Go reported 'An error occurred setting up the container: install features: lockfile: lockfile does not match' in both."
1125
1129
1126
1130
- id: up.compose-frozen-lockfile-missing-failure
1131
+
lock: feature-content-image
1127
1132
lane: runtime
1128
1133
command: up
1129
1134
priority: p1
@@ -1151,6 +1156,7 @@ initial_cases:
1151
1156
notes: "JSON.stringify writes properties in insertion order: the result as readConfiguration's literal lists them, the configuration in its document's order with configFilePath last, featuresConfiguration as FeaturesConfig's literal (featureSets, dstFolder), mergedConfiguration as mergeConfiguration builds it (the configuration without replaceProperties, then the properties it sets). Go wrote every object with sorted keys. Nested user objects keep sorted keys (docs/DIVERGENCES.md)."
1152
1157
1153
1158
- id: up.include-configurations-key-order-success
1159
+
lock: feature-content-image
1154
1160
lane: runtime
1155
1161
command: up
1156
1162
priority: p1
@@ -1271,6 +1277,7 @@ initial_cases:
1271
1277
notes: "up mounts the additionalMountString read-configuration reports: TS spawnDevContainer passes it as a --mount after the workspace mount (singleContainer.ts), so the container has the worktree and its common dir."
1272
1278
1273
1279
- id: build.lockfile-written-by-default-success
1280
+
lock: feature-content-image
1274
1281
lane: runtime
1275
1282
command: build
1276
1283
priority: p1
@@ -1287,6 +1294,7 @@ initial_cases:
1287
1294
notes: "TS writes devcontainer-lock.json on every build with Features unless --no-lockfile is given (containerFeaturesConfiguration.ts generateFeaturesConfig -> writeLockfile, which creates the file); it records the OCI Feature, pinned to its digest, and leaves the local one out. Go wrote it only with --experimental-lockfile or --frozen-lockfile."
1288
1295
1289
1296
- id: build.no-lockfile-writes-none-success
1297
+
lock: feature-content-image
1290
1298
lane: runtime
1291
1299
command: build
1292
1300
priority: p1
@@ -1302,6 +1310,7 @@ initial_cases:
1302
1310
notes: "--no-lockfile disables writing the lockfile (generateFeaturesConfig skips writeLockfile): the configuration folder holds no devcontainer-lock.json after the build."
notes: "A .devcontainer.json gets .devcontainer-lock.json next to it (lockfile.ts getLockfilePath); with only a local Feature (under .devcontainer/, where TS requires it) the lockfile's features map is empty, and TS still writes it."
1317
1326
1318
1327
- id: up.lockfile-rewrites-stale-success
1328
+
lock: feature-content-image
1319
1329
lane: runtime
1320
1330
command: up
1321
1331
priority: p1
@@ -1332,6 +1342,7 @@ initial_cases:
1332
1342
notes: "up rewrites a stale lockfile with the resolved Features by default (writeLockfile replaces content whose JSON.parse -> JSON.stringify differs). Go left an existing lockfile alone without a lockfile flag."
1333
1343
1334
1344
- id: up.no-lockfile-leaves-lockfile-success
1345
+
lock: feature-content-image
1335
1346
lane: runtime
1336
1347
command: up
1337
1348
priority: p1
@@ -1346,6 +1357,7 @@ initial_cases:
1346
1357
notes: "--no-lockfile neither reads nor writes the lockfile: a stale one is left as it was."
notes: "The Compose path resolves the Features through the same generateFeaturesConfig (dockerCompose.ts -> getExtendImageBuildInfo) and writes the lockfile by default. Go wrote it only with a lockfile flag."
0 commit comments