You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7637342
Browse filesBrowse the repository at this point in the historyBrowse files
fix(features): write Feature ENV lines and options in declared order
The image's ENV lines for a Feature's containerEnv and the config's
containerEnv, and the user's options in devcontainer-features.env, were
written in sorted key order. The reference CLI writes them in JS
property order (integer-index keys ascending, then declaration order).
Besides the order itself, a Feature's ENV line that uses a variable an
earlier line sets, such as PATH=${SDKMAN_DIR}/bin:${PATH} after
SDKMAN_DIR, expanded to a different value when the sort put it first,
so the built image's environment differed.
The member order is now recorded where the documents are parsed
(devcontainer-feature.json, devcontainer.json and its override,
--additional-features) and carried to the generated Dockerfile through
features.PropertyOrder.
The two ts-oracle cases recorded as unresolved divergences now match
TS, a TS-generated ts-features-build golden pins the dependent ENV
lines, and a runtime parity case compares the built image's env and
devcontainer-features.env with the reference.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: docs/parity/parity-matrix.yaml
+14Lines changed: 14 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -1079,6 +1079,20 @@ initial_cases:
1079
1079
current_status: match
1080
1080
notes: "Without BuildKit, TS builds the dev_container_feature_content_temp image from the features folder and COPYs /tmp/build-features/hello_0 to /tmp/dev-container-features/hello_0 (kept in the image), so verify_cmd also compares the staged devcontainer-features.env and the devcontainer-features-install.sh banner (getFeatureInstallWrapperScript). Go used to copy from the build context to /tmp/build-features/_dev_container_feature_0."
notes: "TS writes a Feature's containerEnv as ENV lines in devcontainer-feature.json's order and the config's containerEnv in devcontainer.json's (generateContainerEnvs, Object.keys), and devcontainer-features.env lists the options the Feature declares, then the user's other options in the user's order (getFeatureValueObject). The Feature's PATH line uses SDKMAN_DIR, which the line before it sets, so the image's PATH starts with /usr/local/sdkman/bin. Go sorted the keys: PATH came first and expanded an unset SDKMAN_DIR to /bin, ALPHA preceded ZED, and AA preceded ZZ."
0 commit comments