Add array return type to BaseContext::getTranslationResources()#41
Merged
Merged
Conversation
Jean-Beru
reviewed
May 14, 2026
Behat 4 enforces ': array' on TranslatableContext::getTranslationResources(). Without this, soyuka/contexts is incompatible with Behat 4 due to the parent having a stricter signature than the child. The method body is unchanged - glob() already returns an array on this path. Behat 3 stays supported: the 3.x interface has no return type, and PHP covariance allows a child to add one, so this is not a BC break.
Shine-neko
force-pushed
the
fix/behat-4-return-type
branch
from
3838f3b to
26db129
Compare
Collaborator
|
Thanks @Shine-neko ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behat 4 enforces
: arrayonTranslatableContext::getTranslationResources().Without this,
soyuka/contextsis incompatible with Behat 4 due to the parent interface having a stricter signature than the child.The method body is unchanged —
glob()already returns an array on this path.Behat 3 stays supported: the 3.x interface has no return type, and PHP covariance allows a child to add one, so this is not a BC break.
Encountered while migrating a Symfony 7 → 8 project that depends on Behat 4.x.