Skip to content

Commit a823543

Browse files
claude[bot]github-actions[bot]claudebrendan-kellam
authored
chore: upgrade nodemailer to ^10.0.2 to address GHSA-6vj9-mwq6-2f5v, GHSA-8vvx-rff5-p5rq (#1703)
* chore: upgrade nodemailer to ^10.0.2 to address GHSA-6vj9-mwq6-2f5v, GHSA-8vvx-rff5-p5rq nodemailer 10 ships its own type declarations, where SentMessageInfo.pending is optional. Default it to an empty array before concatenating. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore: add CHANGELOG entry for #1703 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Brendan Kellam <brendan@sourcebot.dev>
1 parent a88bc7f commit a823543

6 files changed

Lines changed: 11 additions & 10 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99

1010
### Fixed
1111
- Silenced a false-positive `MaxListenersExceededWarning` logged on every request proxied through an external rewrite. [#1697](https://github.com/sourcebot-dev/sourcebot/pull/1697)
12+
- Upgraded `nodemailer` to `^10.0.2`. [#1703](https://github.com/sourcebot-dev/sourcebot/pull/1703)
1213
- Upgraded `markdown-it` to `^14.3.2`. [#1702](https://github.com/sourcebot-dev/sourcebot/pull/1702)
1314
- Fixed Ask model selections reverting to a stale default after the model configuration changed during a browser session. [#1710](https://github.com/sourcebot-dev/sourcebot/pull/1710)
1415
- Upgraded `next` to `^16.3.8`. [#1709](https://github.com/sourcebot-dev/sourcebot/pull/1709)

‎packages/web/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@
166166
"next-auth": "^5.0.0-beta.32",
167167
"next-navigation-guard": "^0.2.0",
168168
"next-themes": "^0.3.0",
169-
"nodemailer": "^9.0.1",
169+
"nodemailer": "^10.0.2",
170170
"octokit": "^4.1.3",
171171
"openai": "^4.98.0",
172172
"parse-diff": "^0.11.1",

‎packages/web/src/auth.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export const getProviders = async () => {
9999
text: `Log in to Sourcebot using this code: ${token}`
100100
});
101101

102-
const failed = result.rejected.concat(result.pending).filter(Boolean);
102+
const failed = result.rejected.concat(result.pending ?? []).filter(Boolean);
103103
if (failed.length) {
104104
throw new Error(`Email(s) (${failed.join(", ")}) could not be sent`);
105105
}

‎packages/web/src/features/membership/actions/accountRequests.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ export const createAccountRequest = async () => sew(async () => {
113113
text: `New account request for ${org.name} on Sourcebot by ${user.name ?? user.email}`,
114114
});
115115

116-
const failed = result.rejected.concat(result.pending).filter(Boolean);
116+
const failed = result.rejected.concat(result.pending ?? []).filter(Boolean);
117117
if (failed.length > 0) {
118118
logger.error(`Failed to send account request email to ${ownerEmails.join(', ')}: ${failed}`);
119119
}
@@ -220,7 +220,7 @@ export const approveAccountRequest = async (requestId: string) => sew(async () =
220220
text: `Your request to join ${org.name} on Sourcebot has been approved. You can now access the organization at ${env.AUTH_URL}`,
221221
});
222222

223-
const failed = result.rejected.concat(result.pending).filter(Boolean);
223+
const failed = result.rejected.concat(result.pending ?? []).filter(Boolean);
224224
if (failed.length > 0) {
225225
logger.error(`Failed to send approval email to ${request.requestedBy.email}: ${failed}`);
226226
}

‎packages/web/src/features/membership/actions/invites.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ export const createInvites = async (emails: string[]): Promise<{ success: boolea
173173
text: `Join ${invite.org.name} on Sourcebot by clicking here: ${inviteLink}`,
174174
});
175175

176-
const failed = result.rejected.concat(result.pending).filter(Boolean);
176+
const failed = result.rejected.concat(result.pending ?? []).filter(Boolean);
177177
if (failed.length > 0) {
178178
logger.error(`Failed to send invite email to ${email}: ${failed}`);
179179
}

‎yarn.lock‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9179,7 +9179,7 @@ __metadata:
91799179
next-auth: "npm:^5.0.0-beta.32"
91809180
next-navigation-guard: "npm:^0.2.0"
91819181
next-themes: "npm:^0.3.0"
9182-
nodemailer: "npm:^9.0.1"
9182+
nodemailer: "npm:^10.0.2"
91839183
npm-run-all: "npm:^4.1.5"
91849184
octokit: "npm:^4.1.3"
91859185
openai: "npm:^4.98.0"
@@ -18596,10 +18596,10 @@ __metadata:
1859618596
languageName: node
1859718597
linkType: hard
1859818598

18599-
"nodemailer@npm:^9.0.1":
18600-
version: 9.1.1
18601-
resolution: "nodemailer@npm:9.1.1"
18602-
checksum: 10c0/b213a2a906697a735f6eb21103629b7a77aeac297b6d843efd4588157999bf6d19381853ac1224e472f5a34aec2e2412444151a2c6ec6e8c52150afa3055039c
18599+
"nodemailer@npm:^10.0.2":
18600+
version: 10.0.13
18601+
resolution: "nodemailer@npm:10.0.13"
18602+
checksum: 10c0/3004362415e977a3fdf2a0c0ec0ad9fd3724d5ccba3951763bd28fa13a6b87cab13e790c934ccb66b6657ca8149a7efc4cc973867760588169efd8ec3fb99908
1860318603
languageName: node
1860418604
linkType: hard
1860518605

0 commit comments

Comments
 (0)