Skip to content

Commit 727191b

Browse files
fix(ci): drop [skip ci] from release commits so cloud builds run on release (#1696)
* fix(ci): dispatch cloud prod release from the production release workflow The release commit is marked `[skip ci]`, which also suppresses the push event for the release tag, so release-cloud-prod.yml never ran on tag push. Dispatch it explicitly against the new tag from release-prod.yml, and fail fast in release-cloud-prod.yml when it is run from a non-tag ref. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(ci): drop [skip ci] from release commits instead of dispatching cloud prod `[skip ci]` on the release commit also suppressed the push event for the release tag, so release-cloud-prod.yml never ran on tag push. Removing it lets the tag push trigger the cloud prod build (and the main push trigger the cloud staging build), so the explicit dispatch job is no longer needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent d85c29c commit 727191b

2 files changed

Lines changed: 17 additions & 1 deletion

File tree

‎.github/workflows/release-cloud-prod.yml‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,23 @@ concurrency:
1414
cancel-in-progress: false
1515

1616
jobs:
17+
# The image tags below are only enabled for `v*` tag refs. Fail fast with a
18+
# clear error when dispatched from a branch rather than letting buildx fail
19+
# with "tag is needed when pushing to registry".
20+
validate-ref:
21+
runs-on: ubuntu-latest
22+
steps:
23+
- name: Require a release tag ref
24+
env:
25+
REF: ${{ github.ref }}
26+
run: |
27+
if [[ "$REF" != refs/tags/v* ]]; then
28+
echo "::error::Cloud production releases must run against a release tag (got '$REF'). Re-run with: gh workflow run release-cloud-prod.yml --ref v<version>"
29+
exit 1
30+
fi
31+
1732
build:
33+
needs: validate-ref
1834
uses: ./.github/workflows/_build-cloud.yml
1935
with:
2036
environment: prod

‎.github/workflows/release-prod.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ jobs:
145145
- name: Commit changes
146146
run: |
147147
git add CHANGELOG.md packages/shared/src/version.ts docs/api-reference/sourcebot-public.openapi.json
148-
git commit -m "[skip ci] Release v$VERSION"
148+
git commit -m "Release v$VERSION"
149149
150150
- name: Push to temporary branch
151151
id: push_temp_branch

0 commit comments

Comments
 (0)